Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffers not freed at TASK_STATE_FINISHED #25

Open
lauritzthamsen opened this issue Sep 22, 2014 · 1 comment
Open

Buffers not freed at TASK_STATE_FINISHED #25

lauritzthamsen opened this issue Sep 22, 2014 · 1 comment
Labels
bug

Comments

@lauritzthamsen
Copy link
Member

Running this OperatorTest fails even though all tuples are being processed correctly because buffers are currently still being freed when the TASK_STATE_FINISHED event is received:

2014-09-22 14:51:41,794 | INFO FSM-Source2-0-EventDispatcher - CHANGE STATE OF TASK Source2 [e8de05ca-9efa-4284-9df5-2a8f4e7f5954] FROM TASK_STATE_RUNNING TO TASK_STATE_FINISHED [TASK_TRANSITION_FINISH]
2014-09-22 14:51:44,288 | ERROR FSM-Join1-0-EventDispatcher - 1 buffers are not freed.
java.lang.IllegalStateException: 1 buffers are not freed.
at de.tuberlin.aura.core.memory.BufferAllocator.checkForMemoryLeaks(BufferAllocator.java:163)
at de.tuberlin.aura.core.memory.BufferAllocatorGroup.checkForMemoryLeaks(BufferAllocatorGroup.java:157)
at de.tuberlin.aura.taskmanager.TaskDriver.teardownDriver(TaskDriver.java:209)
at de.tuberlin.aura.taskmanager.TaskExecutionUnit$ExecutionUnitRunner$2.stateAction(TaskExecutionUnit.java:190)
at de.tuberlin.aura.taskmanager.TaskExecutionUnit$ExecutionUnitRunner$2.stateAction(TaskExecutionUnit.java:181)
at de.tuberlin.aura.core.common.statemachine.StateMachine$FiniteStateMachine$3.handleEvent(StateMachine.java:424)
at de.tuberlin.aura.core.common.eventsystem.EventDispatcher.dispatch(EventDispatcher.java:324)
at de.tuberlin.aura.core.common.eventsystem.EventDispatcher.access$300(EventDispatcher.java:23)
at de.tuberlin.aura.core.common.eventsystem.EventDispatcher$1.run(EventDispatcher.java:91)
at java.lang.Thread.run(Thread.java:745)
@lauritzthamsen lauritzthamsen changed the title buffers are not freed at TASK_STATE_FINISHED Buffers not freed at TASK_STATE_FINISHED Sep 22, 2014
@lauritzthamsen
Copy link
Member Author

Adding a Timeout to the TaskDriver's tearDownDriver() before the calls to checkForMemoryLeaks() prevents the exception in the given OperatorTest, indicating that the problem is a timing problem.

lauritzthamsen added a commit to lauritzthamsen/AURA that referenced this issue Sep 26, 2014
@lauritzthamsen
Temporary workaround for dos-group#25
7ba6ac3 
 dos-group#25 = buffers are currently still being freed when the TASK_STATE_FINISHED
 arrives, yet when that event arrives it is checked without synchronization
 that all buffers have been freed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lauritzthamsen