Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown link checker can't handle the case where Dockerfiles are added or moved #5871

Closed
lbussell opened this issue Sep 10, 2024 · 2 comments

Comments

@lbussell
Copy link
Contributor

The auto-generated tags tables contain absolute links to the individual Dockerfiles for each image.

If you submit a PR that moves Dockerfiles like this one, then the link checker will always fail since the links are not live yet (the PR has not been merged and the files don't exist).

Related: #5818
/cc @MichaelSimons

@lbussell
Copy link
Contributor Author

[Triage]

Some potential solution ideas:

  • Use relative links in tags tables since the tags table is no longer posted to DockerHub
  • Accept merging on red
  • Only run the markdown link checker on a schedule so that it only checks the live markdown files.

Of these, the first seems the most promising. It would still fail when adding new Docker repos, but that is infrequent enough that it's not a big issue.

@lbussell lbussell moved this from Backlog to Current Release in .NET Docker Sep 16, 2024
@lbussell
Copy link
Contributor Author

[Triage] This was fixed with a change to ImageBuilder tags table generation: dotnet/docker-tools#1446

@github-project-automation github-project-automation bot moved this from Current Release to Done in .NET Docker Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant