Reset MouseIsOver when the control loses focus #12598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12598 +/- ##
===================================================
+ Coverage 75.73242% 76.01419% +0.28176%
===================================================
Files 3153 3175 +22
Lines 635807 638857 +3050
Branches 46975 47178 +203
===================================================
+ Hits 481512 485622 +4110
+ Misses 150870 149737 -1133
- Partials 3425 3498 +73
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
changed the title
LeafShi1
changed the title
LeafShi1
added
the
waiting-review
|
I proceeded to test this PR and the issue has been resolved:
All LGTM! |
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ComboBox/ComboBox.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Show resolved
Hide resolved
LeafShi1
commented
Dec 12, 2024
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ComboBox/ComboBox.cs
Show resolved
Hide resolved
LeafShi1
added
the
waiting-review
LeafShi1
added
the
📬 waiting-for-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12590
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
When change the RightToLeft property after expanding the Popup FlatStyle comboBox, the dropdown button on the comboBox disappeared
After
The dropdown button on the comboBox can be show normally
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow