Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark Mode] The nodes of TreeView not in dark mode when editing it #12042

Open
Zheng-Li01 opened this issue Sep 4, 2024 · 1 comment · May be fixed by #12672 or #12674
Open

[Dark Mode] The nodes of TreeView not in dark mode when editing it #12042

Zheng-Li01 opened this issue Sep 4, 2024 · 1 comment · May be fixed by #12672 or #12674
Labels
area-DarkMode Issues relating to Dark Mode feature 🚧 work in progress Work that is current in progress help wanted Good issue for external contributors
Milestone
Help wanted

Comments

@Zheng-Li01
Copy link
Member

.NET version

.NET 9.0.100-rc.2.24453.35

Did it work in .NET Framework?

No

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: #11857

Issue description

The nodes of TreeeView not in dark mode when editing it, and the issue also can reproduce ItemView item when editing it.
image
GHNewIssue

Steps to reproduce

  1. Create a .NET Winforms project with TreeView control.
  2. Add some node for treeview1, and set the LabelEdit value as True.
  3. Enable DarkMode by Application.SetColorMode(SystemColorMode.Dark) in Program.cs file
  4. Build and run the application
  5. Edit the node, and observe the results.

Reproduce application:
ReproduceApplication.zip
@Zheng-Li01 Zheng-Li01 added untriaged The team needs to look at this issue in the next triage area-DarkMode Issues relating to Dark Mode feature labels Sep 4, 2024
@merriemcgaw merriemcgaw changed the title [Dark Mode] The nodes of TreeeView not in dark mode when editing it [Dark Mode] The nodes of TreeView not in dark mode when editing it Sep 4, 2024
@merriemcgaw merriemcgaw removed the untriaged The team needs to look at this issue in the next triage label Sep 4, 2024
@merriemcgaw merriemcgaw added this to the .NET 10.0 milestone Sep 4, 2024
@merriemcgaw merriemcgaw added the help wanted Good issue for external contributors label Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestones: .NET 10.0, Help wanted Sep 4, 2024
@merriemcgaw merriemcgaw added untriaged The team needs to look at this issue in the next triage help wanted Good issue for external contributors and removed help wanted Good issue for external contributors untriaged The team needs to look at this issue in the next triage labels Sep 4, 2024
pcblues added a commit to pcblues/winforms that referenced this issue Dec 20, 2024
@pcblues
Add ScratchProject2 project for testing dotnet#12042
6632fc2
@pcblues
Copy link

pcblues commented Dec 21, 2024 •
edited
Loading

I have completed the modifications to show the edit labels in the dark theme for the TreeView and ListView.

Is it standard behaviour in the ListView in Dark Mode for the selected focused ListItem to be blue?

Image

pcblues added a commit to pcblues/winforms that referenced this issue Dec 21, 2024
@pcblues
Changes for dotnet#12042 to prep for pull request
f68fedc
pcblues added a commit to pcblues/winforms that referenced this issue Dec 21, 2024
@pcblues
Merge branch 'main' into Mods-for-dotnet#12042
db63d99
pcblues added a commit to pcblues/winforms that referenced this issue Dec 21, 2024
@pcblues
Merge pull request #1 from pcblues/Mods-for-#12042
6513a3d 
Pull request for Issue dotnet#12042
@pcblues pcblues linked a pull request Dec 23, 2024 that will close this issue
Draft
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Dec 23, 2024
pcblues added a commit to pcblues/winforms that referenced this issue Dec 23, 2024
@pcblues
Changes to main branch to address dotnet#12042
739a255
@pcblues pcblues linked a pull request Dec 23, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-DarkMode Issues relating to Dark Mode feature 🚧 work in progress Work that is current in progress help wanted Good issue for external contributors
Projects
None yet
Milestone
Help wanted
Development

Successfully merging a pull request may close this issue.

Mods for #12042 pcblues/winforms
Changes to main branch to address #12042 pcblues/winforms
3 participants
@pcblues @merriemcgaw @Zheng-Li01