Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

problem importing UTF-8 encoded files #74

Open
tjaartvdwalt opened this issue Nov 8, 2016 · 6 comments
Open

problem importing UTF-8 encoded files #74

tjaartvdwalt opened this issue Nov 8, 2016 · 6 comments

Comments

@tjaartvdwalt
Copy link

tjaartvdwalt commented Nov 8, 2016

Hi, thank for a great plugin.

I get the following problem that I hope you can help me with. I want to use bourbon with my project. When I import the main sass file, I get the following exception:

system.src.js:122 Uncaught (in promise) Error: (SystemJS) Error: Invalid CSS after "3": expected "{", was ""
	        on line 37 of bourbon/bourbon/library/margin.scss
	>> 3
	   ^

In order to reproduce the error, I have created a small sample application:
https://github.com/tjaartvdwalt/systemjs-sass-plugin-example

After some experimentation, it seems this error has to do with the fact that the file is UTF-8 encoded.

@jgillich
Copy link

Isn't everything UTF-8 encoded these days? But yea, I also have no idea how to get this plugin working.

// js
System.import('./styles/style.sass!');
// style.sass
@import 'jspm:bulma/bulma.sass'

results in

Uncaught (in promise) Error: (SystemJS) Error: Invalid CSS after "@charset": expected 1 selector or at-rule, was '"utf-8"'
	        on line 2 of http://localhost:8080/jspm_packages/npm/[email protected]/bulma.sass
	>> @charset "utf-8"
	   --------^

Ping @screendriver @sormy any ideas?

@screendriver
Copy link
Collaborator

Hi there,

thank you for the feedback. Yes it seems that @charset "UTF-8"; could not be interpreted as valid SASS. Unfortunately I can't do there anything (respectively I believe that 🤔 ). I parse all your input files as string and delegate everything to sass.js.

So I think we should open an issue there and see if there is anything we could do with the sass.js parser.

@esbie
Copy link

esbie commented Jan 3, 2017

Now that medialize/sass.js#72 is resolved and released as part of 0.10.0, is this issue fixable/fixed? Would love to use this plugin, but bourbon is holding me back ;)

@screendriver
Copy link
Collaborator

This plugin is abandoned. Unfortunately we switched the technology and don't have the time and bugdet to maintain this plugin anymore.

I updated the README. However everyone can maintain this plugin furthermore (we would transfer the whole project to the user)

@dougludlow
Copy link
Owner

I think all we need to do is update our version of sass.js here and then we can move forward, does that sound right?

@esbie
Copy link

esbie commented Feb 27, 2017

That's my understanding, yeah. Or if that doesn't fix the issue, there's a filesystem workaround as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants