Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch protocol to a multitoken contract #243

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

drewcook
Copy link
Owner

@drewcook drewcook commented Dec 25, 2022

General Changes

  • Switch from ERC-721 to ERC-1155 for managing non-fungible tokens on Arbor Collections

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • New third-party packages, if any, do not introduce potential security threats
  • There are no CI changes, or they have been OK’d by the devops team
  • Code changes have been quality checked in the ephemeral URL
  • There is at least one approval from the core team
  • Squash and merge has been checked

@drewcook drewcook temporarily deployed to arbor-pr-243 December 25, 2022 03:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the singular ERC-721 collection into ERC-1155 multi-token collection
2 participants