Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add in view for what projects a particular stem has been used o… #225

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Add in view for what projects a particular stem has been used o… #225

wants to merge 5 commits into from

Conversation

0xlws
Copy link
Collaborator

@0xlws 0xlws commented Dec 17, 2022

…n #220

General Changes

  • Fixes XYZ bug
  • Adds XYZ feature
  • …

Developer Notes

Add any notes here that may be helpful for reviewers.

Author Checklist

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

Reviewer Checklist

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • New third-party packages, if any, do not introduce potential security threats
  • There are no CI changes, or they have been OK’d by the devops team
  • Code changes have been quality checked in the ephemeral URL
  • There is at least one approval from the core team
  • Squash and merge has been checked

@vercel
Copy link

vercel bot commented Dec 17, 2022

@0xlws is attempting to deploy a commit to the Arbor Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@0xlws 0xlws linked an issue Dec 17, 2022 that may be closed by this pull request
Add in view for what projects a particular stem has been used on #220
Open
@0xlws
Copy link
Collaborator Author

0xlws commented Dec 20, 2022 •
edited
Loading

so far this should get which projects the stem was used in, noticed it should leave out the current.
if any comments please let me know

@drewcook drewcook marked this pull request as ready for review December 23, 2022 04:42
@drewcook drewcook temporarily deployed to arbor-pr-225 December 23, 2022 04:43 Inactive
drewcook
drewcook requested changes Dec 23, 2022
View reviewed changes
pages/stems/[id].tsx Outdated Show resolved Hide resolved
pages/stems/[id].tsx Outdated Show resolved Hide resolved
pages/stems/[id].tsx Show resolved Hide resolved
@0xlws 0xlws requested a review from drewcook January 12, 2023 21:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 12, 2023
View reviewed changes
pages/api/stems/[id]/collaborations.ts
switch (method) {
case 'GET':
try {
const projects: IProjectDoc[] = await Project.find({ 'stems._id': id }).populate('stems')

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query depends on a [user-provided value](1).
@drewcook drewcook temporarily deployed to arbor-pr-225 January 19, 2023 05:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewcook drewcook Awaiting requested review from drewcook

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add in view for what projects a particular stem has been used on
2 participants
@0xlws @drewcook