Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeable doesn't detect the wip label #103

Open
cornelius opened this issue Jan 25, 2019 · 5 comments
Open

Mergeable doesn't detect the wip label #103

cornelius opened this issue Jan 25, 2019 · 5 comments
Assignees
Labels
repo Configuration of the repository itself

Comments

@cornelius
Copy link
Member

Mergeable is supposed to block pull request from merging which have the wip label set. This doesn't seem to work anymore. I saw it on #102.

This is kind of a special pull requests because it changed the mergeable configuration, but the wip config was not touched, so it shouldn't have made a difference. Another weird thing was that mergeable hang after the pull request was approved. Changing labels retriggered it successfully but also showed the problem with the wip label.

@cornelius cornelius added the repo Configuration of the repository itself label Jan 25, 2019
@scravy
Copy link
Member

scravy commented Jan 25, 2019

That's proably upper vs lower case.

@cornelius
Copy link
Member Author

The configuration seems to look for lower case (as is the label): https://github.com/dtr-org/unit-e-docs/blob/8b0b8cfb292e0f1a3ba98558f49178b660e931ee/.github/mergeable.yml#L8

@scravy
Copy link
Member

scravy commented Jan 25, 2019

Interesting. Did it look for lower case before too?

Does the WIP: mechanism for titles still work?

@cornelius
Copy link
Member Author

This setting was the same before. I will test what works and will try to find a solution.

@cornelius cornelius self-assigned this Jan 25, 2019
@cornelius
Copy link
Member Author

I couldn't reproduce the issue, neither in a separate repo, nor in this repo. I'll watch how it behaves with future pull requests.

The regular expression is applied with the case insensitive flag in the code, so that can't be the issue. Good to know that the case doesn't matter, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Configuration of the repository itself
Projects
None yet
Development

No branches or pull requests

2 participants