Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=~ matching in run.sh causes "duckdb-latest" to match "duckdb" #30

Open
jangorecki opened this issue Aug 12, 2023 · 2 comments
Open

=~ matching in run.sh causes "duckdb-latest" to match "duckdb" #30

jangorecki opened this issue Aug 12, 2023 · 2 comments

Comments

@jangorecki
Copy link

jangorecki commented Aug 12, 2023

Commit 17d41db that introduced solution "duckdb-latest" is causing that the following line in run.sh

if [[ "$RUN_SOLUTIONS" =~ "duckdb" ]]; then ./duckdb/ver-duckdb.sh; fi;

is matching to duckdb even when duckdb is not being used, but only duckdb-latest. As a result benchmark may fail with the following message:

Error in read.dcf(system.file(package = "duckdb", lib.loc = "./duckdb/r-duckdb",  : 
  cannot open the connection
In addition: Warning message:
In read.dcf(system.file(package = "duckdb", lib.loc = "./duckdb/r-duckdb",  :
  cannot open compressed file '', probable reason 'No such file or directory'
Execution halted

To resolve it we should use more precise operator than =~, till then let's keep this issue open in case someone will be getting such error and trying to search for it.

@grantmcdermott
Copy link

Related: Can't we just "drop" the duckdb-latest runs and make this the default for DuckDB?

The duplication is a little confusing and unnecessary since the 0.9 release.

@jangorecki
Copy link
Author

I think it is desired for duckdb team to have both version presented to compare performance between stable and devel. I would maybe suggest to trim the name so it fits better on the plots, possibly duckdb-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants