Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding matmul symbol or similar #145

Open
jwoo098 opened this issue Oct 24, 2024 · 2 comments
Open

Consider adding matmul symbol or similar #145

jwoo098 opened this issue Oct 24, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jwoo098
Copy link
Contributor

jwoo098 commented Oct 24, 2024

A symbol that would return the matrix product of two arrays (similar to numpy.matmul)

@arcondello arcondello added the enhancement New feature or request label Oct 31, 2024
@jlalbers
Copy link
Contributor

jlalbers commented Nov 5, 2024

Also brings up the question of how to handle a transpose, as these operations are frequently paired. Seems a bit heavy-handed to create a new node just to handle it, but it could also be a huge pain to implement within the node itself and might not be consistent with the design philosophy of other parts of the model.

@arcondello
Copy link
Member

arcondello commented Nov 5, 2024

It would be a new node, similar to the existing ReshapeNode. The good news is that by messing around with strides etc, we can avoid having to hold the array at all! We would need to do some transposition of the updates that are propagated. But overall the node would be pretty light weight.

It also wouldn't support dynamic arrays, because arrays can only be dynamic in the 0th axis.

Added an issue #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants