Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chracter-set issues #500

Open
UltraBlackLinux opened this issue Nov 5, 2024 · 8 comments
Open

Chracter-set issues #500

UltraBlackLinux opened this issue Nov 5, 2024 · 8 comments

Comments

@UltraBlackLinux
Copy link

Hey there,
A few of the artists and music in my library contain japanese characters, but they don't properly show within supersonic desktop:
image
Here are the titles and some more examples:

'ネザーnether - SLUSHWAVE 2024.mp3'
'憂鬱 - End.mp3'
'猫 シ Corp. - FORUM 消費者[kuluttaja].mp3'
'猫 シ Corp. & t e l e p a t h テレパシー能力者 - Blue  Dream.mp3'
'秋 - Live @ Slushwave 2024.mp3'
'秋 - 私はまだあなたが必要です + 屋久島 + 大山隠岐国 + 夜間 (extended version).mp3'

I'm on SSD v0.13.1.
Any chance that you could fix this?
Thanks!

@dweymouth
Copy link
Owner

Supersonic loads fonts from the OS as needed to display characters not in the base font, but this does look like a character encoding issue, like your files are not tagged with UTF-8 metadata. Do you know the character set encoding of your media file tags? It seems it's currently assuming everything is UTF-8 (which is the default in the Go programming language and on most modern systems). I also have not run into a non-UTF-8 tagged media file myself. I may need you to attach a media file here or email me one to test with before I can look into this issue. I guess Supersonic will need to use some character encoding library to detect encodings of all the file tags and convert them to UTF-8 on the fly if needed?

@UltraBlackLinux
Copy link
Author

UltraBlackLinux commented Nov 5, 2024

I have honestly no idea how to check that. They display fine in my terminal and that is using UTF-8:

LANG=en_GB.UTF-8
LC_CTYPE=en_GB.UTF-8
LC_NUMERIC="en_GB.UTF-8"
LC_TIME="en_GB.UTF-8"
LC_COLLATE="en_GB.UTF-8"
LC_MONETARY="en_GB.UTF-8"
LC_MESSAGES="en_GB.UTF-8"
LC_PAPER="en_GB.UTF-8"
LC_NAME="en_GB.UTF-8"
LC_ADDRESS="en_GB.UTF-8"
LC_TELEPHONE="en_GB.UTF-8"
LC_MEASUREMENT="en_GB.UTF-8"
LC_IDENTIFICATION="en_GB.UTF-8"
LC_ALL=

Here's some files that you could grab with yt-dl - that's how I got them: https://www.youtube.com/watch?v=_45xy5o4uj8&list=PLSBYfyLFV5VHV8Tj4BKlNYHqcUQcE0E0f

@UltraBlackLinux
Copy link
Author

UltraBlackLinux commented Nov 11, 2024

Hm I just noticed that if you show the track info for a track with these characters it shows the correct filename, but it doesn't in the "Artists" section. Maybe something went wrong during file tagging...

I used id3v2 for that, and it shows all characters correctly.

I did however also just notice that supersonic crashed when I pressed the "copy" button next to the track name, maybe something on supersonic's side after all

@thecivilizedgamer
Copy link

I just installed Supersonic, it looks and works great so far, nice work! The experience is very polished.

However, I'm seeing something similar on Xubuntu 24.04. I haven't dug into any details yet, but Japanese characters are showing fine in Nextcloud Music and not in Supersonic. I'll attach screenshots, let me know what info I can provide.
Screenshot_2024-11-25_23-35-52
Screenshot_2024-11-25_23-34-38

@dweymouth
Copy link
Owner

dweymouth commented Nov 26, 2024

@thecivilizedgamer Your issue is different and probably easy to solve - yours is just that Supersonic (or rather the Fyne UI toolkit) cannot find a suitable font to show Japanese characters. You could try installing the fonts-noto-cjk apt package and it might solve it for you.

Edit: also make sure you are using the latest version, 0.13.1

@thecivilizedgamer
Copy link

@thecivilizedgamer Your issue is different and probably easy to solve - yours is just that Supersonic (or rather the Fyne UI toolkit) cannot find a suitable font to show Japanese characters. You could try installing the fonts-noto-cjk apt package and it might solve it for you.

Edit: also make sure you are using the latest version, 0.13.1

Hmmm, looks like I already have that package installed, but I'll do some more googling to see if I can isolate the problem. And I'm on 0.13.1 (the Flatpak version).

@dweymouth
Copy link
Owner

Hmm, perhaps try the direct installation if you're able. It's possible Flatpak permissions could be preventing the OS font lookup from happening

@thecivilizedgamer
Copy link

I just did the direct install, and it works fine now :) When I downloaded the archive, I saw the Makefile and assumed that was for installing from source, so that's why I initially went with the Flatpak option. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants