Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations #65

Open
dweymouth opened this issue Mar 5, 2023 · 40 comments
Open

Translations #65

dweymouth opened this issue Mar 5, 2023 · 40 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dweymouth
Copy link
Owner

dweymouth commented Mar 5, 2023 •
edited
Loading

First, need to decide on an i18n library, then recruit volunteers to translate!

If anyone wants to pre-volunteer to be a translator, please comment here with the language(s) you'd be able to translate,and I'll circle back once I'm ready to add i18n!
@dweymouth dweymouth added the enhancement New feature or request label Mar 5, 2023
@dweymouth dweymouth pinned this issue Mar 8, 2023
@dweymouth dweymouth added the help wanted Extra attention is needed label Mar 16, 2023
@valterbarreira
Copy link

I could help translating to Portuguese

@second2falcon
Copy link

second2falcon commented Aug 21, 2023 •
edited
Loading

I could do Dutch and/or German (if I find the time, because of school and work).

Just tell me what to do.

@Wu-Haitao
Copy link

I could support Chinese translation ✋

@Mister-Digital
Copy link
Contributor

I can help with the translation into German

@ItsEricRao
Copy link

I can also do Chinese translations. Thanks for maintaining the project 🙃

@Tuba2
Copy link
Contributor

Tuba2 commented Apr 8, 2024 •
edited
Loading

I can do Brazilian Portuguese 😃

@alessandrococco
Copy link
Contributor

I can help with Italian :-)

@Ericwyn
Copy link
Contributor

Ericwyn commented Jul 15, 2024

I can also do Chinese translations. This is a great project. Thank you

@dweymouth
Copy link
Owner Author

The good news is the UI toolkit now supports translations! The bad news is it will still be a lot of work to hunt down all the hard-coded strings and come up with the list of every string in the app that needs to be translated. But I'll update here again when prep work has been done

@dweymouth dweymouth mentioned this issue Jul 21, 2024
Merged
@dweymouth
Copy link
Owner Author

dweymouth commented Jul 21, 2024 •
edited
Loading

OK - translation prep work is done and translations are open!

To submit a translation, open a PR that copies res/translations/en.json to a new file for your language with the language code (e.g. res/translations/es.json) and translate the strings! It's not necessary to translate 100% of the strings but it would be ideal. NOTE: on startup the app will load the translation for your operating system's locale, if it exists.

@dweymouth
Copy link
Owner Author

If submitting translations via pull request isn't convenient, I can also just accept a link to the new <lang>.json file from Pastebin or similar service

@Ericwyn
Copy link
Contributor

Ericwyn commented Jul 24, 2024

If submitting translations via pull request isn't convenient, I can also just accept a link to the new <lang>.json file from Pastebin or similar service

Sounds great, I was wondering if I translate it into Chinese, what kind of names should I use for Simplified Chinese and Traditional Chinese?
zh.json or zhHans.json or zhHant.json ?

Also how do I preview the translation? I've cloned the latest code of the project and run it successfully, but I don't seem to see a language switch button

Anyway, thanks for your work.

@Ericwyn
Copy link
Contributor

Ericwyn commented Jul 24, 2024 •
edited
Loading

I've found that fyne v 2.5.0 currently has an anomaly where it reads br.json by default on startup instead of the user's locally set language issue.

So even though I added zh.json, it didn't preview it.

One solution would be to copy the file to br.json in order to preview the current translation.

But the correct solution would be to update the fyne version

dweymouth added a commit that referenced this issue Jul 24, 2024
@dweymouth
Updates #65: update Fyne to get latest i18n bug fixes
6d08bfb
@dweymouth dweymouth linked a pull request Jul 24, 2024 that will close this issue
i18n: add chinese translation #430
Merged
@dweymouth dweymouth removed a link to a pull request Jul 24, 2024
i18n: add chinese translation #430
Merged
@dweymouth dweymouth mentioned this issue Jul 24, 2024
Merged
@dweymouth
Copy link
Owner Author

@Ericwyn just checking, were you able to check locally that it selects the correct variant (simplified vs traditional) based on the system locale? It's not very well documented yet so I don't know exactly what the language variant filenames should be, but if it's working then those were the correct names!

@dweymouth dweymouth mentioned this issue Jul 26, 2024
Merged
@joker197cinque
Copy link

joker197cinque commented Jul 29, 2024 •
edited
Loading

Hallo, I just updated to 0.13.0 version on Windows and I noticed that UI language changed. How can I do to force it to stay English ?

@dweymouth
Copy link
Owner Author

Hallo, I just updated to 0.13.0 version on Windows and I noticed that UI language changed. How can I do to force it to stay English ?

What language did it open in for you (Italian or Chinese)? It picks up the language from your OS's locale settings. Do you have English configured in your OS as one of your preferred languages? (It can be second or lower in priority to your main language?)

@joker197cinque
Copy link

joker197cinque commented Jul 29, 2024 via email

@dweymouth
Copy link
Owner Author

It's currently not possible to force a specific language because the UI framework did not expose an API to do so. But I can probably hack something in if it's enough of a problem. It's interesting that it isn't getting your OS's locale settings correctly though? because that seemed pretty solid when I tested it

@alessandrococco
Copy link
Contributor

Also, is not possible to force English language? I kindly suggest it to be customizable because some terms are soooo ugly when translated 😂

Ciao! Ho fatto io la traduzione. Mi potresti fare qualche esempio di traduzione "ugly", così da migliorarla? Non c'è stata una vera e propria revisione dei testi per cui è possibile/probabile che qualcosa mi sia sfuggito, probabilmente possiamo trovare dei termini migliori! Grazie! 😄

@joker197cinque
Copy link

joker197cinque commented Jul 29, 2024 via email

@joker197cinque
Copy link

joker197cinque commented Jul 29, 2024 via email

@alessandrococco
Copy link
Contributor

Ciao Ale e grazie per il tuo contributo 👏🏻. Con ugly intendo che, a mio avviso, alcuni termini non sono traducibili.. ad esempio Shuffle no lo tradurrei mai con Mescola in ambito musicale.. però capisco che la traduzione letterale è quella 😅 Che ne pensi? 🙏

Di nulla :-D

Concordo, alcuni termini sono difficili/brutti da tradurre. Su "Shuffle" sono stato in dubbio fino all'ultimo, "Mescola" non mi ha mai convinto al 100% e non suona proprio bene... Forse in ambito player musicale è più corretto lasciare "shuffle"?)

Appena ho un attimo cerco di fare un'altra passata sui testi e di rivedere alcune cose qua e là - Accetto volentieri idee/suggerimenti ;)

@joker197cinque
Copy link

joker197cinque commented Jul 29, 2024 via email

@Tuba2
Copy link
Contributor

Tuba2 commented Jul 29, 2024

@alessandrococco @joker197cinque

In portoghese usiamo i termini "Aleatório" o "Ordem Aleatória", che possono essere tradotti come "Casuale" o "Ordine Casuale".

Possono essere opzioni valide per voi ;)

@joker197cinque
Copy link

joker197cinque commented Jul 29, 2024 via email

@Tuba2
Copy link
Contributor

Tuba2 commented Jul 29, 2024

@joker197cinque Ho visto dopo, hai postato mentre stavo scrivendo 😅

@GioF71
Copy link

GioF71 commented Jul 31, 2024 •
edited
Loading

Hello @alessandrococco (and thank you for implementing the italian translating) and @joker197cinque, I was also smiling when I saw "Mescola", of course it's not wrong at all. Maybe "Ordine casuale" is the one that looks and sounds better IMO.

Edit: I just realized that the button starts playback in random order. I thought it would shuffle the album view somehow, and would not start playback directly.
So could a long string like "Riproduci in ordine casuale" fit in?

@joker197cinque
Copy link

joker197cinque commented Jul 31, 2024 via email

@alessandrococco
Copy link
Contributor

Translation updated, see #445, thank you all for your feedback!

@benoit-smith
Copy link
Contributor

Please may I help with a French translation?

@Masterlocker
Copy link
Contributor

@benoit-smith sure. Fork the repo then go to res>translations copy en.json and name it fr.json and edit words on the right.

@Masterlocker
Copy link
Contributor

@benoit-smith also add at the end

"to": "to",
"by": "by"

@second2falcon
Copy link

second2falcon commented Jul 31, 2024 •
edited
Loading

@benoit-smith also add at the end

"to": "to",

"by": "by"

Should've heard that a bit sooner. I opened a PR a few hours ago. Will close it and open a new one (if it hasn't been merged yet).

@second2falcon second2falcon mentioned this issue Jul 31, 2024
Closed
@Masterlocker
Copy link
Contributor

@second2falcon you didn't had to close a PR but just add another commit

@alessandrococco
Copy link
Contributor

@benoit-smith also add at the end

"to": "to",

"by": "by"

Should've heard that a bit sooner. I opened a PR a few hours ago. Will close it and open a new one (if it hasn't been merged yet).

There's no need to open a new PR, just push the new commit to the same branch!

@second2falcon
Copy link

@Masterlocker @alessandrococco it appears I have much to learn about Git.

Also, to and by as in translated to and translated by, or in what context are they used.

@Masterlocker
Copy link
Contributor

"by" like album by artist
"to" like from year 2000 to 2005
@second2falcon

@Tuba2
Copy link
Contributor

Tuba2 commented Aug 6, 2024

Hi, I've just finished translating the app to Brazilian Portuguese.

I have 2 questions:

  1. Should I name the file pt_BR.json or pt-BR.json?

  2. I translated the last two items considering the following instructions:

"by" like album by artist "to" like from year 2000 to 2005 @second2falcon

Are they correct?

That's it.
I just have to know these two things before I make a PR.

@dweymouth
Copy link
Owner Author

should be pt_BR.json. And that is the correct context for the translations of "by" and "to".

I did merge a feature today (tooltips) that added some new strings, so you may want to check and add the strings that were introduced in #455. (This goes for other translators too, when you have a chance, cc. @alessandrococco @Ericwyn @Masterlocker )

@Tuba2
Copy link
Contributor

Tuba2 commented Aug 7, 2024 •
edited
Loading

I had already done the translation after the inclusion of the new strings 😉

PR is done, pt_BR translation is ready to be merged!

I'll also post an Libadwaita theme in the Custom Themes section, after this is merged.

@Underpath Underpath mentioned this issue Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests