Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion for integration with TSFrame #51

Open
smishr opened this issue Sep 15, 2023 · 1 comment
Open

Discussion for integration with TSFrame #51

smishr opened this issue Sep 15, 2023 · 1 comment

Comments

@smishr
Copy link

smishr commented Sep 15, 2023

TSFrames.jl is DataFrames.jl optimised for time-series functionalities. I feel it is pre-eminent time series data structure in Julia, as being a thin wrapper around DataFrames.jl is a huge benefit given the large community support for that package.

I am planning to use both Indicators and TSFrames for my work, and I've started building the wrappers to use the algorithms in Indicators on TSFrame structures. Currently planning to send PR as a package extension to TSFrames.jl. issue, PR.

This is an appropriate use case of the Julia 1.9+ package extension functionalities. But im not sure which package should be weak dependency of the other? Since I'm extending methods of this package dispatched on struct from another, Indicators could add TSFrames as weak dependency.

I'm wondering if its a good idea and there is consensus for adding it as a feature/extension in Indicators.jl, similar to the integration with Temporal.jl here. Although I'm not convinced these should be full dependencies. What are the community thoughts?

@femtotrader
Copy link
Contributor

Just a little comment to let you know that I'm currently working on https://github.com/femtotrader/IncTA.jl it's a library which calculate Technical Analysis Indicators in Julia in an incremental approach (like talipp in Python).
There is very few dependencies (currently OnelineStatsBase and OnelineStats... and I'm considering removing dependencies to OnelineStats keeping only OnelineStatsBase dependencies).
See discussion https://discourse.julialang.org/t/incremental-technical-analysis-indicators/107844/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants