Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cvi-styles to cvi-ng as a peer dependency #73

Open
certainlyakey opened this issue Apr 3, 2023 · 0 comments
Open

Include cvi-styles to cvi-ng as a peer dependency #73

certainlyakey opened this issue Apr 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@certainlyakey
Copy link
Contributor

What happened?

Right now cvi-styles is de facto a dependency of cvi-ng. You get either a build error or unstyled Angular components if you don't install cvi-styles to your project. But it's not mentioned in any way.

It would be good to have this indicated in a more prominent way.

Reproduction steps

  1. Go to README and package.json
  2. Check the deps and text

Screenshot

No response

Package

Angular

Version

1.7.0

Reproduction URL

No response

Browser

No response

Browser version

No response

Extra details about your environment

No response

Relevant log output

No response

@certainlyakey certainlyakey added the bug Something isn't working label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant