Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directories that don't contain any library files shouldn't be added to $LD_LIBRARY_PATH #3504

Open
stdweird opened this issue Nov 20, 2020 · 3 comments
Labels
Milestone

Comments

@stdweird
Copy link
Contributor

not a bug, just a bit confusing sometimes.

not sure what pattern th elinker looks for, but i guess files with name lib* or somthing like that

@boegel boegel transferred this issue from easybuilders/easybuild Nov 20, 2020
@boegel boegel added this to the 4.x milestone Nov 20, 2020
@boegel boegel changed the title directories that don't containe any libs shouldn't be added to LD_LIBRARY_PATH directories that don't contain any library files shouldn't be added to $LD_LIBRARY_PATH Nov 20, 2020
@boegel
Copy link
Member

boegel commented Nov 20, 2020

We could add a check to only add lib directories that contain files (or files starting with lib*) to $LD_LIBRARY_PATH, but we have to be a bit careful with this...

There may not be files present yet when generating the temporary module file before installing extensions for example, but lib* files may get added when installing extensions.

For the final module file (non-fake mode), a check like this should be OK?

@bartoldeman
Copy link
Contributor

This relates to
#3145
although we were mostly discussing header files there.

as a second check one could also check for *.so* files that don't necessarily start with lib

@boegel boegel modified the milestones: 4.x, 4.4.0 Dec 1, 2020
@boegel boegel modified the milestones: 4.3.3, release after 4.3.3 Feb 3, 2021
@boegel boegel modified the milestones: 4.4.0, release after 4.4.0 May 25, 2021
@boegel boegel modified the milestones: 4.4.2, release after 4.4.2 Sep 1, 2021
@boegel boegel modified the milestones: 4.5.0, release after 4.5.0 Oct 13, 2021
@boegel boegel modified the milestones: 4.5.1, release after 4.5.1 Dec 7, 2021
@boegel boegel modified the milestones: next release (4.5.2?), 4.x Jan 14, 2022
@boegel boegel added the EasyBuild-5.0 EasyBuild 5.0 label Jan 31, 2024
@boegel boegel modified the milestones: 4.x, 5.0 Jan 31, 2024
@boegel boegel changed the title directories that don't contain any library files shouldn't be added to $LD_LIBRARY_PATH directories that don't contain any library files shouldn't be added to $LD_LIBRARY_PATH Jan 31, 2024
@boegel boegel moved this to Nice-to-have in EasyBuild v5.0 Aug 26, 2024
@lexming
Copy link
Contributor

lexming commented Sep 24, 2024

#4653 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Nice-to-have
Development

No branches or pull requests

4 participants