Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions module to PyLIMA #89

Open
rachel3834 opened this issue Aug 7, 2024 · 1 comment
Open

Add exceptions module to PyLIMA #89

rachel3834 opened this issue Aug 7, 2024 · 1 comment
Assignees

Comments

@rachel3834
Copy link
Collaborator

PyLIMA's internal error checking is really great for robust fitting but there are occasions when this causes a fit process to end prematurely. This is fine, but in these circumstances, it would be really helpful if PyLIMA had an exceptions module which could then be imported in to fitting pipelines to improve their handling of exceptional cases.

Here's an example of this use-case:

I have a wrapper code which uses PyLIMA to run automated modeling of a set of events. In a few rare cases, PyLIMA's functions for eliminating bad data in the input lightcurves results in one or more lightcurves that are empty. This causes pyLIMA to halt the model fit, rightly.
I would like to be able to import a PyLIMA exceptions model so that I can add a specific try-except clause to catch these cases, without having to make it so broad as to catch every exception, which would tend to mask other issues.

@ebachelet
Copy link
Owner

Agree but this will take time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants