Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove endorsement compatibility completely #3036

Open
hui-an-yang opened this issue Sep 5, 2024 · 0 comments
Open

Remove endorsement compatibility completely #3036

hui-an-yang opened this issue Sep 5, 2024 · 0 comments
Assignees
@hui-an-yang
Labels
quebec rpc
Milestone
v21

Comments

@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Sep 5, 2024 •
edited
Loading

Breaking changes client’s encoding with legacy attestation name are no longer supported starting from protocol following ParisC. (MR !13454)
Remove with_legacy_attestation_name encodings from the protocol environment. (MR !14046)
balance_update_encoding_with_legacy_attestation_name has been removed. (MR !13461)
Encoding that supports endorsement kind in apply_result JSON has been removed. (MR !13974)
Encoding that supports endorsement kind in operation JSON has been removed. (MR !13976)

remove endorsement in all places where it fits

Remove support for deprecated version 0 from RPCs POST ../helpers/parse/operations, POST ../helpers/scripts/run_operation and POST ../helpers/scripts/simulate_operation. (MR !13451)

RPC call prior Q was having the option to specified version 0 to use endorsement instead of attestation for compatability and in at least runOperation and simulateOperation
Would be good to go through all rpc endpoints using RPCOptions in openAPI to see if it's good to remove RPCOptions.version: 0 for good
@hui-an-yang hui-an-yang changed the title RPC update remove RPCOptions.version 0 Remove endorsement compatibility completely Sep 5, 2024
@dsawali dsawali added this to the v21 milestone Sep 5, 2024
hui-an-yang added a commit that referenced this issue Sep 6, 2024
@hui-an-yang
feat: removed endorsement compatiblity but kept rpc types and readPro…
2ccc4ee 
…vider for user query old block

BREAKING CHANGE: PollingSubscribeProvider doesn't filter endorsement anymore and removed rpc
entrypoints using param version  0

re #3036
@hui-an-yang hui-an-yang mentioned this issue Sep 9, 2024
Closed
9 tasks
@hui-an-yang hui-an-yang moved this from To do to Review in progress in Taquito Dev Sep 27, 2024
@hui-an-yang hui-an-yang self-assigned this Oct 2, 2024
@hui-an-yang hui-an-yang linked a pull request Oct 2, 2024 that will close this issue
Betanet0829 #3040
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
quebec rpc
Projects
Taquito Dev
Status: Review in progress
Milestone
v21
Development

Successfully merging a pull request may close this issue.

Betanet0829 ecadlabs/taquito
2 participants
@dsawali @hui-an-yang