Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio Code Integration theme support #1431

Open
akera-io opened this issue Nov 26, 2024 · 1 comment
Open

Visual Studio Code Integration theme support #1431

akera-io opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request vscode

Comments

@akera-io
Copy link

The VSCode integration already uses VSCode CSS variables for sprotty graph/node/edge, problem is with text which remained the default color (black). Depending on the theme selected some of the text in the diagram is almost not visible - either labels inside the nodes or on the edges.

Override fill color for sprotty text in diagram.css:

/* most of the time the labels are inside the nodes */
.sprotty text {
fill: var(--vscode-editor-background);
}

/* for edges background is the graph: --vscode-editor-background */
.sprotty-edge text {
fill: var(--vscode-foreground);
}

@akera-io akera-io added the enhancement New feature or request label Nov 26, 2024
@planger planger added the vscode label Nov 26, 2024
@martin-fleck-at
Copy link
Contributor

@akera-io Thank you for reporting this issue! In general this change looks reasonable to me, would you like to open a PR for it so we can do a proper review on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode
Projects
None yet
Development

No branches or pull requests

3 participants