Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Allow contribution of options for GlspVscodeConnector - Messenger #1455

Open
tortmayr opened this issue Dec 18, 2024 Discussed in #1454 · 0 comments
Open

Request: Allow contribution of options for GlspVscodeConnector - Messenger #1455

tortmayr opened this issue Dec 18, 2024 Discussed in #1454 · 0 comments

Comments

@tortmayr
Copy link
Contributor

Discussed in #1454

Originally posted by jmenzies12 December 18, 2024
Hey there,

The VSCode Messenger has an option called 'ignoreHiddenViews', this is set to true when constructed without passing in any options. This stops the diagram client from receiving any action messages etc. whenever the webview is considered hidden, for example if you have it as one of your tabs but it is not the editor in focus.

This causes issues in our project whenever someone changes tab to edit our source model, as the message sent from the source model to the webview never arrives at the client, resulting in the model not updating.

Unfortunately Messenger is declared as read-only in GlspVscodeConnector, so I had to copy GlspVscodeConnector and GlspEditorProvider in order to pass the options in for this.

It would be great if you could add a way for us to provide this in future.

Kind Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant