Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MicronautGenerator: Lambda can be replaced with method reference #3370

Closed
manusa opened this issue Sep 6, 2024 · 4 comments · Fixed by #3599
Closed

MicronautGenerator: Lambda can be replaced with method reference #3370

manusa opened this issue Sep 6, 2024 · 4 comments · Fixed by #3599
Assignees
@rahulgupta0409
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone
1.18.0

Comments

@manusa
Copy link
Member

manusa commented Sep 6, 2024 •
edited
Loading

Description

The class MicronautGenerator presents the issue: Lambda can be replaced with method reference.

The following line:

jkube/jkube-kit/jkube-kit-micronaut/src/main/java/org/eclipse/jkube/micronaut/generator/MicronautGenerator.java

Line 52 in e2c44f4

return nestedGenerator.getEnv(ppp -> super.getEnv(ppp), prePackagePhase);

should be changed to:

        return nestedGenerator.getEnv(super::getEnv, prePackagePhase);

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.
@manusa manusa added first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers labels Sep 6, 2024
@devchh
Copy link

devchh commented Sep 9, 2024

Hey @manusa! Can I be assigned this?

@manusa
Copy link
Member Author

manusa commented Sep 25, 2024

Hey @manusa! Can I be assigned this?

Hi @devchh

It's been 2 weeks since the issue was assigned, are you still working on it or I can assign to someone else?

@devchh
Copy link

devchh commented Sep 26, 2024

Hey @manusa ! Hope you're well. Just need to finish the log in stuff. Should be done sometime this week. Sorry for this just caught up.

@rahulgupta0409
Copy link
Contributor

Hi @manusa ,
I want to work on this issue,
could you please assign this to me.

thanks

rahulgupta0409 added a commit to rahulgupta0409/jkube that referenced this issue Dec 25, 2024
@rahulgupta0409
Refactor: eclipse-jkube#3370: MicronautGenerator: Replaced Lambda exp…
63c60db 
…ression with Method reference.
@rahulgupta0409 rahulgupta0409 mentioned this issue Dec 25, 2024
Merged
17 tasks
@manusa manusa added this to the 1.18.0 milestone Dec 27, 2024 — with automated-tasks
manusa added a commit that referenced this issue Dec 27, 2024
@rahulgupta0409 @manusa
fix: suppressed replace lambda with method reference warning in Micro…
8aa8ca0 
…nautGenerator (3599)

Refactor: #3370: MicronautGenerator: Replaced Lambda expression with Method reference.
---
fix: suppressed replace lambda with method reference warning in MicronautGenerator

Signed-off-by: Marc Nuri <[email protected]>

Co-authored-by: Marc Nuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulgupta0409 rahulgupta0409

Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Milestone
1.18.0
3 participants
@manusa @rahulgupta0409 @devchh