Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#830 Add module-info to the modules #843

Merged
merged 1 commit into from
Aug 20, 2024
Merged

#830 Add module-info to the modules #843

merged 1 commit into from
Aug 20, 2024

Conversation

Thihup
Copy link
Contributor

@Thihup Thihup commented Jun 10, 2024

No description provided.

@jonahgraham jonahgraham linked an issue Jun 10, 2024 that may be closed by this pull request
Add module-info to the modules #830
Open
jonahgraham
jonahgraham approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I would like if a second set of eyes could look as I don't use/write module-info.java as part of my normal work so I don't know what may be needed here.

If there are no objections in a reasonable amount of time I will happily merge as is.

Thank you @Thihup for this contribution.

@andirady
Copy link

Tested using the --list-modules flag of the java command, and it lists the modules correctly and does not complain about any split packages.

$ java --module-path $(find -name "*-SNAPSHOT.jar" -exec echo -n '{}:' \;) --list-modules
...
org.eclipse.lsp4j file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j/build/libs/org.eclipse.lsp4j-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.debug file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.debug/build/libs/org.eclipse.lsp4j.debug-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.generator file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.generator/build/libs/org.eclipse.lsp4j.generator-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.jsonrpc file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.jsonrpc/build/libs/org.eclipse.lsp4j.jsonrpc-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.jsonrpc.debug file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.jsonrpc.debug/build/libs/org.eclipse.lsp4j.jsonrpc.debug-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.websocket file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.websocket/build/libs/org.eclipse.lsp4j.websocket-0.24.0-SNAPSHOT.jar
org.eclipse.lsp4j.websocket.jakarta file:///home/andirady/code/github/lsp4j/./org.eclipse.lsp4j.websocket.jakarta/build/libs/org.eclipse.lsp4j.websocket.jakarta-0.24.0-SNAPSHOT.jar

@jonahgraham
Copy link
Contributor

Thanks @andirady for the second set of eyes on this.

@jonahgraham jonahgraham added this to the 0.24.0 milestone Aug 20, 2024
@jonahgraham jonahgraham merged commit 7ce4f59 into eclipse-lsp4j:main Aug 20, 2024
4 checks passed
@cdietrich
Copy link
Contributor

seems to cause #855

@travkin79
Copy link

Thank you @cdietrich for looking into this. I checked out the previous commit (f235e91) and there seems to be no problem with building that version. Thus, the issue has likely something to do with this change.

Nevertheless, there seem to be multiple potential causes for the issue I described in #855 (maybe one of: bug in JDT, bug in PDE, bug in buildship, bug in some gradle plug-in, bug in gson library,... in some way related to Java's module system).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Add module-info to the modules
5 participants
@Thihup @andirady @jonahgraham @cdietrich @travkin79