Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully use resource name length for created Kubernetes resources #327

Open
lucas-koehler opened this issue Jul 19, 2024 · 0 comments
Open
Labels
enhancement New feature or request prio-low

Comments

@lucas-koehler
Copy link
Contributor

Follow up of #326 .

The name calculation in NamingUtil#createName(String prefix, String identifier, String user, String appDefinition, String uid) can be improved to use all available characters dependent on the length of the parameters.
I.e. if a parameter is shorter than the allocated length, the remaining characters can be re-distributed to the other parameters.
Furthermore, we want to use at most 57 characters for session specific objects so Kubernetes can attach 6 characters for the pod created from the deployment.
For workspace related resources, we can use the full 63 characters though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio-low
Projects
None yet
Development

No branches or pull requests

2 participants