Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NoStackTraceThrowable with NoStackTraceException #4854

Open
magicprinc opened this issue Sep 12, 2023 · 2 comments
Open

Replace NoStackTraceThrowable with NoStackTraceException #4854

magicprinc opened this issue Sep 12, 2023 · 2 comments
Labels
bug

Comments

@magicprinc
Copy link
Contributor

magicprinc commented Sep 12, 2023 •
edited
Loading

Vert.x historically uses NoStackTraceThrowable (extends Throwable) for lightweight exception without heavy stack trace collection process.

But:

  1. Since 2023 there is NoStackTraceException whith the same meaning which extends VertxException (RuntimeException).
  2. Extending Throwable is considered a bad practice.
@magicprinc magicprinc added the bug label Sep 12, 2023
magicprinc added a commit to magicprinc/vert.x that referenced this issue Sep 12, 2023
@magicprinc
Replace NoStackTraceThrowable with NoStackTraceException eclipse-vert…
3a03dd5 
…x#4854
@magicprinc magicprinc mentioned this issue Sep 12, 2023
Open
@magicprinc
Copy link
Contributor Author

PR: #4855

@magicprinc magicprinc mentioned this issue Sep 12, 2023
Open
This was referenced Dec 5, 2023
Closed
Open
@senyaak
Copy link

senyaak commented Nov 5, 2024

Any change it will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magicprinc @senyaak