Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {Metal,K3s}-QEMU-SNP-GPU platforms #1091

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 19, 2024

This adds a new K3s-QEMU-SNP-GPU platform that can be used for testing GPU-specific features on our on-prem infrastructure that uses this setup. This intentionally does not yet add any specific actions done if that platform is selected.

@msanft msanft added the no changelog PRs not listed in the release notes label Dec 19, 2024
@msanft msanft force-pushed the msanft/k3s-qemu-gpu-platform branch from ae7c9ea to e535a27 Compare December 19, 2024 10:50
This adds a new `K3s-QEMU-SNP-GPU` platform that can be used for testing GPU-specific features on our on-prem infrastructure that uses this setup. This intentionally does not yet add any specific actions done if that platform is selected.
@katexochen
Copy link
Member

I thinks this should also add Metal-QEMU-SNP-GPU at the same time, which I expect to be needed.

@msanft
Copy link
Contributor Author

msanft commented Dec 20, 2024

I thinks this should also add Metal-QEMU-SNP-GPU at the same time, which I expect to be needed.

My initial thought was to split these to keep a minimal diff, but I also think combining these will make sense. Will do so!

@msanft msanft changed the title Add K3s-QEMU-SNP-GPU platform Add {Metal,K3s}-QEMU-SNP-GPU platforms Dec 20, 2024
@katexochen katexochen added the needs: rework PR author needs to work in feedback label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: rework PR author needs to work in feedback no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants