Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pb-views in closed pb-panels will still cause pb-update events #185

Open
DrRataplan opened this issue Nov 6, 2024 · 0 comments · May be fixed by #186
Open

pb-views in closed pb-panels will still cause pb-update events #185

DrRataplan opened this issue Nov 6, 2024 · 0 comments · May be fixed by #186

Comments

@DrRataplan
Copy link
Contributor

This causes strange behaviour depending on which panels have been open or closed.

Take BEBB (https://bebb.jinntec.de/home.html), an app that displays two columns: a transcribed view and a facsimile. The transcribed view can be a page-by-page or a whole view. If the page-by-page view is open, we want the pb-navigation buttons in the toolbar to show up. All communication is going through one channel only: all subscribe and emit are the same.

The problem is that the whole view is the initially open one. If you then use the facsimile to navigate between pages, the whole view is updated, emitting a pb-update that the document is opened in the all-pages mode. This then triggers the facsimile view to update to the first page. Even if the whole view is closed. There are small work-arounds in place in some cases, but they do not cover all ways to change the navigation (they cover the pb-navigation buttons by not using the facsimile to navigate).

Can we deactivate hidden panels? This should make the app a lot more predictable: everything counts as an initial open and hidden panels do not affect application state.

@DrRataplan DrRataplan linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant