Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-tify codepen demo is broken #183

Open
duckyb opened this issue Oct 7, 2024 · 1 comment · May be fixed by #187
Open

pb-tify codepen demo is broken #183

duckyb opened this issue Oct 7, 2024 · 1 comment · May be fixed by #187
Assignees
@DrRataplan

Comments

@duckyb
Copy link

duckyb commented Oct 7, 2024

The demo for pb-tify is not working.

Steps to reproduce

  1. Navigate to https://cdn.tei-publisher.com/@2.23.2/dist/api.html#pb-tify.1
  2. Click on "Edit code" button
  3. Notice pb-view not loading in the lower part of the window

image

Expected behavior

I expect pb-tify to load as seen on the demo page:

image
@duckyb
Copy link
Author

duckyb commented Oct 7, 2024

The problem is that pb-tify.js is not being loaded in the codepen demo.

adding this tag fixes the issue:

<script type="module" src="https://unpkg.com/@teipublisher/pb-components@latest/dist/pb-tify.js"></script>

@DrRataplan DrRataplan self-assigned this Nov 6, 2024
@DrRataplan DrRataplan linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrRataplan DrRataplan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add import of pb-tify in pb-tify demo codepen eeditiones/tei-publisher-components
2 participants
@DrRataplan @duckyb