Investigate LSP support on Windows

[jiribenes]

On Windows, the extension packaged from #20 gets stuck somewhere when starting the LSP server:

On a "Restart LSP server" command, it shows:

Again, note that this might be because of #20, you should better test anew with & without it.
It might be useful to use the [helpful, albeit fiddly] debug mode Effekt LSP offers.

[OriginalCpp]

I am using Windows.

1. I installed the compiler and then the extension from the vs code marketplace and got the following error when opening an Effekt-file:
   
2. I debugged the extension after cloning the repository and got the following:
   

For further testing, I would need some instructions because I don't know much wether about vs code extensions nor about language servers and Effekt

[jiribenes]

Hi @OriginalCpp, thanks for tackling this.
First, I have a few questions:

1. Is Effekt installed? (can you run effekt in the console?)
   • It doesn't seem like it, would you consider either installing it manually (see the website https://effekt-lang.org) or via the Effekt Version Manager: automatic installer and updater #20 branch?
   • If it's not installed, please install Effekt first, otherwise there's no LSP server to connect to making the issue untenable ;)
2. By the way, do you use WSL2 with VSCode or not? :) (this is just for my info)

---

If there are still problems (please check both the main branch [= the current released version of the extension] and the branch in #20), here are first steps:

1. For debugging/running the extension, you might need to run npm install in the effekt-vscode folder (to get all of the developer dependencies). You can also just build it using vsce, see the CI for more details.
2. For debugging the language server part, you can use the debug option in the config of the VSCode extension:

Based on the code that added it 29dd4ae, I think that when using this mode, you need to run the Effekt LSP separately with effekt --server --debug as per: https://github.com/effekt-lang/kiama/blob/ab6aef78fc4ce99a9ad2db8555718d00b03f7b8a/jvm/src/main/scala/kiama/util/Server.scala#L100-L120

If everything works on your machine for both the main and #20, let me know :)
Please post your questions/progress here.

[OriginalCpp]

I checked if I installed Effekt, and indeed I have:

I use WSL2 with VSCode for a Cpp Course I will take soon, but usually I do not use it. When testing this I was also not connected to the WSL

Main

I had to run the LSP seperately when the Debug option was activated. Then debugged the extension, opening an effekt-file and everything worked, but in the console there were some warnings:

#20

Also ran the LSP seperately, everything worked fine:

[jiribenes]

Thanks for the update, what's the status of the issue then? Does it work without the debug flag for you?

[OriginalCpp]

Without the debug option enabled:

Main

#20

[jiribenes]

Could you try setting your Effekt executable in the plugin settings to effekt.sh or effekt.cmd or effekt.ps1 (or other options you can find in the same folder where Effekt installed (where/which effekt)?

Also, could you try investigating around for a source of the spawn EINVAL?
Could it be something like this? https://code.visualstudio.com/updates/v1_92#_electron-30-update
If so, can we go around it? (Here's some quick workaround I found: https://github.com/microsoft/vscode-vsce/blob/main/src/package.ts#L409, but I'm not sure where to apply it here)

Could you also see if it can be caused by too recent / too old Node.js version?

Thanks!

[OriginalCpp]

#20

.cmd

The testing in my last post, I already set the Effekt executable to effekt.cmd:

.sh

When using the effekt.sh endless powershell windows kept opening and I got the following errors:

.ps1

It somehow randomly opens the file .ps1 in the editor too.
And I get similar errors:

.sh.cmd

Somehow when setting it to this, it does not find the path:

.sh.ps1

As with .ps1 it keeps opening the file. Also not working, "Effekt Server has stopped" and not even any errors anywhere reported.

Main

.cmd

Already tested earlier

.sh

Same problem as with #20 testing. I do not think testing the other file extensions would deliver any other results.

Node.js version

Spawn EINVAL

The fix you mentioned includes this https://stackoverflow.com/a/78532006, so maybe it is fixed if the shell: true option gets added where the process is spawned. I can't seem to find that line though to try it.

[jiribenes]

Should be fixed by the following commit (now live on #20): 71ae96e
If needed, we can cherry-pick it to master directly.

[OriginalCpp]

Yes, now it works on my machine (using the effekt.cmd in the options).