Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: true ignored when used with @rollup/plugin-node-resolve #369

Open
BryceMehring opened this issue Aug 7, 2023 · 1 comment
Open

Comments

@BryceMehring
Copy link

Same issue as rollup/plugins#1267.

I'm getting

(!) Unresolved dependencies
https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency
zlib (imported by "zlib?commonjs-external")
http (imported by "http?commonjs-external")
https (imported by "https?commonjs-external")
assert (imported by "assert?commonjs-external")
stream (imported by "stream?commonjs-external")

What fixes this problem is running this plugin as:

{
  ...esbuild(),
  resolveId: undefined,
}
@tbrannam
Copy link

tbrannam commented Apr 8, 2024

In my environment I needed to replace resolveId a little differently.

{
  ...esbuild(),
  resolveId: () => null,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants