Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed flag is set to false when exporting dashboards #2258

Open
taylor-swanson opened this issue Dec 5, 2024 · 1 comment
Open

Managed flag is set to false when exporting dashboards #2258

taylor-swanson opened this issue Dec 5, 2024 · 1 comment

Comments

@taylor-swanson
Copy link
Contributor

When exporting dashboards, either brand new dashboard or an existing managed one made editable by elastic-package, the managed flag on the dashboard (within the exported JSON) is set to false. This may be desirable in some situations, but in most cases, these dashboards are meant for packages managed by fleet, so the desired value should be true.

Image

At the moment, this doesn't seem to cause any issues, since it appears Fleet either overrides this value or ignores it completely. However, many (if not all) of our integrations have managed set to false in checked-in code. Another option would be to not include managed in the JSON at all, but not sure if that's the equivalent to "managed": false.

Another thing to note, adding the managed tag on a dashboard doesn't appear to set the managed flag in the JSON, so as of right now, the only way to set it to true is to edit the JSON.

@jsoriano
Copy link
Member

jsoriano commented Dec 5, 2024

I think we could remove managed when exporting dashboards, as Fleet will set this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants