Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain event.original value upon pipeline errors #12045

Open
2 tasks
andrewkroh opened this issue Dec 9, 2024 · 5 comments
Open
2 tasks

Retain event.original value upon pipeline errors #12045

andrewkroh opened this issue Dec 9, 2024 · 5 comments
Labels
enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Scalability Security Integrations Scalability team Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Dec 9, 2024

When an ingest pipeline error occurs, our log pipelines should retain the event.original value to ensure that no data loss occurs and to facilitate correcting the failure. If processing is interrupted due to an error, some data may not have been extracted (i.e. incomplete processing) so it's important to retain the event.original. And secondly, in order for the package maintainers to be able to take action on reports of pipeline failures they nearly always need the event.original value to reproduce and understand the issue.

To implement this we should complete the work related to #10072. This not strictly required, but it helps ensure the event.original is consistently handled. We want the Fleet final_pipeline to be responsible for deleting event.original when tags does not contain preserve_original_event.

Next, in the primary pipeline of each log data stream we update the global on_failure handler to inject preserve_original_event into tags. This will accompany event.kind: pipeline_error. With this mechanism, users can still override this behavior through the various levels of @custom pipelines by deleting the tag value. I expect the work to be accomplished "mechanically", and this mechanism can be applied separately on the integrations owned by each SIT team.

Tasks

Preview Give feedback
  1. Integration:All enhancement
@andrewkroh andrewkroh added enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Scalability Security Integrations Scalability team Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] labels Dec 9, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

Pinging @elastic/security-scalability (Team:Security-Scalability)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:All Applies to all integrations [Integration not found in source] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Scalability Security Integrations Scalability team Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Development

No branches or pull requests

2 participants