-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Change Proposal] Allow for the configuration of the default deployment mode on a per-integration basis #850
Comments
Yes, this looks like a straightforward change in the spec. Though I am not sure of understanding where this is needed. Once agent policies are created for agentless, cannot they contain only agentless policies? |
A part from the change in package-spec, should this new field be available to Kibana before installing the packages? Or can it be read from the package itself in Kibana? If it is needed to be exposed to Kibana via EPR, it would be needed to update package-registry to include that new field too. |
@smriti0321 could you please answer the questions above before we move forward on this? |
@jsoriano I am not sure I follow the question. Looping in @oren-zohar to pitch in here. From product perspective the ask is to allow integration developer to choose if a specific integration supports agentless as default option or not.
@mrodm I will request someone from engineering to pitch in here. @oren-zohar
|
@jlind23 @smriti0321 @mrodm @jsoriano I'll try to clarify the requirement here a bit policy_templates:
- name: billing
title: AWS Billing
description: Collect billing metrics with Elastic Agent
deployment_modes:
default:
enabled: false
agentless:
enabled: true This change adds the Right now, the default selection for
This functionality is needed before the user has created any agent policies, as it determines the default selection shown on the integration installation page.
I believe Kibana should be able to read the default selection from the package metadata, similar to how it reads the |
If it is required to be shown in the installation page, probably it would be needed to be exposed via API in Elastic Package Registry (EPR). WDYT @jsoriano ? Taking a look to the issue where it was added support for |
Yes, if this is needed at this point we will also need the change in package registry. |
So to summarize:
Right? |
Background
With the plan for CSPM Agentless mode GA in 8.18, the dropdown logic in Kibana will default to agentless. This leads to agentless as default mode if that deployment mode is available for a given integration (for example integrations like Okta and beyond which are going to adopt agentless mode too). This would be a global change for all integrations that support agentless deployment. However, this change might be too broad to implement effectively.
Proposed Solution
Instead of making a broad change, we propose shipping a new flag to the package-spec. This flag would allow integration maintainers to choose the default deployment_mode.
Details
Flag Location: package-spec manifest
Purpose: Allow maintainers to set the default deployment_mode for their integrations.
This would allow the package to define something like
Impact: This change would provide more granular control and flexibility for integration maintainers, ensuring that the default deployment mode is appropriate for each specific integration. Kibana can then render the dropdown with agentless as the default option based on this configuration.
The text was updated successfully, but these errors were encountered: