Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing fast in channel switch dialog (ctrl-K) closes the dialog #28529

Closed
eras opened this issue Nov 23, 2024 · 2 comments
Closed

Typing fast in channel switch dialog (ctrl-K) closes the dialog #28529

eras opened this issue Nov 23, 2024 · 2 comments
Labels
A-Spotlight-Search The new search dialog available in develop and Nightly O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@eras
Copy link

eras commented Nov 23, 2024

Steps to reproduce

  1. Press ctrl-k to open the channel switch dialog
  2. Enter a string so fast that the results don't arrive as fast as your typing
  3. Witness the dialog closing by itself, no channel has been switched

Outcome

What did you expect?

I expected the search to work just as I type more, not have the dialog close by itself.

What happened instead?

..the dialog closed by itself.

In addition, the following relevant messages appeared in the browser console:

TypeError: Node.compareDocumentPosition: Argument 1 is not an object.
    f RovingTabIndex.tsx:95
    y RovingTabIndex.tsx:116
    React 2
    E RovingTabIndex.tsx:213
    React 8
    _ scheduler.production.min.js:13
    T scheduler.production.min.js:14
rageshake.ts:69:16
    t rageshake.ts:69
    React 9
    _ scheduler.production.min.js:13
    T scheduler.production.min.js:14
Uncaught TypeError: Node.compareDocumentPosition: Argument 1 is not an object.
    f RovingTabIndex.tsx:95
    y RovingTabIndex.tsx:116
    React 2
    E RovingTabIndex.tsx:213
    React 8
    _ scheduler.production.min.js:13
    T scheduler.production.min.js:14
RovingTabIndex.tsx:95:32
    f RovingTabIndex.tsx:95
    y RovingTabIndex.tsx:116
    React 2
    E RovingTabIndex.tsx:213
    React 8
    _ scheduler.production.min.js:13
    T scheduler.production.min.js:14

Operating system

Linux Debian 12

Browser information

132.0.2 (64-bit)

URL for webapp

https://tsat.mf.variaattori.fi/element/

Application version

1.11.86

Homeserver

matrix.org

Will you send logs?

No

@eras eras added the T-Defect label Nov 23, 2024
@dosubot dosubot bot added A-Spotlight-Search The new search dialog available in develop and Nightly O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 23, 2024
@eras
Copy link
Author

eras commented Nov 23, 2024

The issue was introduced in v1.1.86, but the file RovingTabIndex.tsx has not changed between versions v1.11.85 and v1.11.86.

However, there are commits after v1.1.86 that do change the file, the major one being 0faf29 that sounds like it's written to fix this exact issue.

@t3chguy
Copy link
Member

t3chguy commented Nov 23, 2024

Duplicate of #28493

@t3chguy t3chguy marked this as a duplicate of #28493 Nov 23, 2024
@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spotlight-Search The new search dialog available in develop and Nightly O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants