Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Mark CallExecutor as ThreadUnsafe or force user to create CallExecutor in every execute call to avoid data race #88

Open
jeremyfu-aws opened this issue Jun 14, 2023 · 1 comment
Open

Mark CallExecutor as ThreadUnsafe or force user to create CallExecutor in every execute call to avoid data race #88

jeremyfu-aws opened this issue Jun 14, 2023 · 1 comment
Labels
enhancement

Comments

@jeremyfu-aws
Copy link

jeremyfu-aws commented Jun 14, 2023 •
edited
Loading

Since CallExecutor has status as instance variable to store result, it is needed to create new CallExecutor in every execute call, otherwise it could cause data race under multi-threaded environment.

In order to avoid the misuse of CallExecutor, please consider to

  • add ThreadUnsafe annotation on CallExecutor
  • or implement in a way which forces users to create new CallExecutor in every execute call
@jeremyfu-aws jeremyfu-aws changed the title Mark CallExecutor as ThreadUnsafe or force user to create CallExecutor in every call to avoid data race Mark CallExecutor as ThreadUnsafe or force user to create CallExecutor in every execute call to avoid data race Jun 14, 2023
@elennick
Copy link
Owner

@jeremyfu-aws i am no longer going to be maintaining retry4j - however please feel free to fork and make whatever changes you'd like

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elennick @jeremyfu-aws