You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In love-exedit.lua in line 382, newdata which is FileData userdata is overwritten by a string if it turns out that the resized icon from the build config is bigger than lvl3_entry.DataSize.
The application then crashes in line 386 because it tries to call FileData:getString on what is no longer FileData.
Wrapping line 382 in a newFileData solves the crash but I have no immediate access to a Windows machine right now to confirm the exe icon is also correct afterwards so I'm opening an issue instead of a PR.
Used icon for repro:
The text was updated successfully, but these errors were encountered:
Okay made some changes to the code in 0.7 - haven't done a release for it yet but seems to at least not crash with that icon now
Seperately seems to be an issue with the zip files for 12.0 source for any of the builds newer than this one: https://github.com/love2d/love/actions/runs/11867071430
Seems to either be an issue with the zip being made, or maybe a change to love.data.decompress, not 100% what's going on
Going to try and investigate that more first so I can check the new 0.7 changes in latest 12 first before releasing
In love-exedit.lua in line 382,
newdata
which is FileData userdata is overwritten by a string if it turns out that the resized icon from the build config is bigger thanlvl3_entry.DataSize
.The application then crashes in line 386 because it tries to call
FileData:getString
on what is no longer FileData.Wrapping line 382 in a
newFileData
solves the crash but I have no immediate access to a Windows machine right now to confirm the exe icon is also correct afterwards so I'm opening an issue instead of a PR.Used icon for repro:
The text was updated successfully, but these errors were encountered: