Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building windows crashes for certain icon sizes #11

Open
Endaris opened this issue Oct 14, 2024 · 2 comments
Open

Building windows crashes for certain icon sizes #11

Endaris opened this issue Oct 14, 2024 · 2 comments

Comments

@Endaris
Copy link
Contributor

Endaris commented Oct 14, 2024

In love-exedit.lua in line 382, newdata which is FileData userdata is overwritten by a string if it turns out that the resized icon from the build config is bigger than lvl3_entry.DataSize.
The application then crashes in line 386 because it tries to call FileData:getString on what is no longer FileData.
Wrapping line 382 in a newFileData solves the crash but I have no immediate access to a Windows machine right now to confirm the exe icon is also correct afterwards so I'm opening an issue instead of a PR.
Used icon for repro:
icon

@ellraiser
Copy link
Owner

Ah nice, will have a look - i know there's less space to play with now in 12 but should still be able to get it working

@ellraiser
Copy link
Owner

Okay made some changes to the code in 0.7 - haven't done a release for it yet but seems to at least not crash with that icon now

Seperately seems to be an issue with the zip files for 12.0 source for any of the builds newer than this one:
https://github.com/love2d/love/actions/runs/11867071430
Seems to either be an issue with the zip being made, or maybe a change to love.data.decompress, not 100% what's going on

Going to try and investigate that more first so I can check the new 0.7 changes in latest 12 first before releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants