Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit:complete-dirname doesnt suggest symlinks to directories #1835

Open
1 task done
SolitudeSF opened this issue Aug 31, 2024 · 3 comments
Open
1 task done

edit:complete-dirname doesnt suggest symlinks to directories #1835

SolitudeSF opened this issue Aug 31, 2024 · 3 comments

Comments

@SolitudeSF
Copy link
Contributor

SolitudeSF commented Aug 31, 2024 •
edited
Loading

What happened, and what did you expect to happen?

edit:complete-dirname doesnt suggest symlinks to directories. it should.

Output of "elvish -version"

0.22.0-dev.0.20240821105340-94dca2081188

Code of Conduct
@SolitudeSF
Copy link
Contributor Author

side-effect is that complete-filename suggest symlinks to directories as files, without adding trailing slash.

@iandol
Copy link
Contributor

iandol commented Nov 10, 2024

It would be great to get this fixed...

@rsteube
Copy link
Contributor

rsteube commented Dec 1, 2024

This should be due to fs.FileInfo.IsDir checking the FileInfo of the symlink.
There's filepath.EvalSymlinks, but the question is whether to fix this in GenerateDirNames (complex predicate) or generateFileNames (inconsistency as predicate is applied to the resolved stat).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
All Elvish issues
Status: ❓Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iandol @rsteube @SolitudeSF