Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No license notice when getting official binaries #1848

Open
1 task done
xiaq opened this issue Oct 15, 2024 · 1 comment
Open
1 task done

No license notice when getting official binaries #1848

xiaq opened this issue Oct 15, 2024 · 1 comment
Labels

Comments

@xiaq
Copy link
Member

xiaq commented Oct 15, 2024

What happened, and what did you expect to happen?

A user who downloads Elvish's official binaries from https://elv.sh/get/ doesn't see any license notice during the process, but they should.

This can be fixed by adding a license notice to either the website or the binary itself (such as via a new -license flag that just prints the license notice). The latter benefits all distributors of the Elvish binary and seems preferable.

Output of "elvish -version"

irrelevant

Code of Conduct

@xiaq xiaq moved this from ❓Triage to 🧑‍💻Code in All Elvish issues Oct 15, 2024
@xiaq xiaq added the bug label Oct 15, 2024
@xiaq
Copy link
Member Author

xiaq commented Oct 21, 2024

Since the binary contains code from dependencies, the user should also be informed of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🧑‍💻Code
Development

No branches or pull requests

1 participant