Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and code is incorrectly stating that encryption is being used. #29

Open
SvenRtbg opened this issue Aug 3, 2017 · 1 comment

Comments

@SvenRtbg
Copy link

SvenRtbg commented Aug 3, 2017

The readme states that both "symmectric encryption" and "asymmetric encryption" is being used.

This is wrong. The algorithms used do not encrypt, they do hash, or sign, the values. However the values remain as clear text, just base64-encoded. They cannot be manipulated this way (only if you use "none" as the signing method), but are open to everyone to read.

This documentation fault is replicated in the namespace of so called Encryption classes, which are only Hashing or Signing classes.

@emarref
Copy link
Owner

emarref commented Aug 3, 2017

Quite right. TBH I don't know how I've never noticed that before. Will look at updating docs. Changing namespaces will have to wait until v2, as modifying namespaces would result in a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants