Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the new anchor functionality in the redesign #882

Open
mansona opened this issue Sep 4, 2023 · 1 comment
Open

use the new anchor functionality in the redesign #882

mansona opened this issue Sep 4, 2023 · 1 comment

Comments

@mansona
Copy link
Member

mansona commented Sep 4, 2023 •
edited
Loading

For example: in the current version of the guides we have a "show on hover" anchor/link thing: https://api.emberjs.com/ember/5.2/classes/Application/methods/advanceReadiness?anchor=boot

Image

The new version looks different and is always visible: https://guides.emberjs.com/release/components/#toc_the-application-template

Image
@mansona mansona converted this from a draft issue Sep 4, 2023
@mansona mansona moved this from Todo to In Progress in Redesign ember-api-docs Sep 4, 2023
@mansona
Copy link
Member Author

mansona commented Sep 4, 2023

@lukasnys said they would do this one 🎉

lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
move anchor image to the end of the title (ember-learn#882)
1595d6e
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
update svg to match guidemaker-ember-template icon (ember-learn#882)
b70a507
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
move click handler to anchor icon (ember-learn#882)
d6f4ca9
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
move now irrelevant test (ember-learn#882)
f824028 
we're no longer hiding the link icon until the header is hovered, which makes this test irrelevant
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
move class-field-description--link class to correct element (ember-le…
1088917 
…arn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
style: style anchor link to match guidemaker-ember-template (ember-l…
d8518b0 
…earn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
rename fa-link.svg to link.svg since its no longer from fa (ember-lea…
b0c5747 
…rn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
style: style anchor link to match guidemaker-ember-template (ember-l…
40776f4 
…earn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
rename fa-link.svg to link.svg since its no longer from fa (ember-lea…
fd84fb5 
…rn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
remove now irrelevant test (ember-learn#882)
815b8b5 
we're no longer hiding the link icon until the header is hovered, which makes this test irrelevant
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
move class-field-description--link class to correct element (ember-le…
a87910e 
…arn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
style: style anchor link to match guidemaker-ember-template (ember-l…
6290402 
…earn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
rename fa-link.svg to link.svg since its no longer from fa (ember-lea…
1680913 
…rn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
fix anchor test (ember-learn#882)
66060d6
@lukasnys lukasnys mentioned this issue Sep 10, 2023
Merged
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
style: style anchor link to match guidemaker-ember-template (ember-l…
1d4ccf4 
…earn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
rename fa-link.svg to link.svg since its no longer from fa (ember-lea…
544dab0 
…rn#882)
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
fix anchor test (ember-learn#882)
000eef1
lukasnys pushed a commit to lukasnys/ember-api-docs that referenced this issue Sep 10, 2023
cleanup: remove unused class (ember-learn#882)
62a632f
@MinThaMie MinThaMie moved this from In Progress to Done in Redesign ember-api-docs Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Redesign ember-api-docs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mansona