-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser-support.hbs to include v5 #1059
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
app/templates/browser-support.hbs
Outdated
</div> | ||
|
||
<h2>Ember 4.0.0</h2> | ||
<h2>Ember 4.0.0 and Ember 5.0.0</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved v4 and v5 to the top as that's what I think most ppl would like to see first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
This seems fine to me but might miss some of the nuance of the browser support policy that started with v4. I am surprised to find #884 never landed. |
@kategengler totally agree! I was pretty sure I would miss some details, but seems like page in current state makes bad impression of being neglected and having some details missed is better than not having totally outdated content. My assumption would be: if there is no wrong content in here and structure looks good, land it and iterate to clarify and refine the details. |
I think that's fine but do still wonder why #884 was never landed. For future reference, browser support is a rolling window for the evergreen browsers that can be updated in each minor. Current support can be seen here https://github.com/emberjs/ember.js/blob/main/lib/browsers.js and this is also exported on Ember's index, so in node This is the relevant RFC https://rfcs.emberjs.com/id/0685-new-browser-support-policy/ |
762783d
to
56d4ade
Compare
https://emberjs.com/browser-support/ states v3 in present tense and talks about v4 in future tense, which is outdated. Also v5 has been released some time ago but page does not mention it.
56d4ade
to
f10fb4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
https://emberjs.com/browser-support/ states v3 in present tense and talks about v4 in future tense, which is outdated.
Also v5 has been released some time ago but page does not mention it.