Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser-support.hbs to include v5 #1059

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

SergeAstapov
Copy link
Contributor

https://emberjs.com/browser-support/ states v3 in present tense and talks about v4 in future tense, which is outdated.

Also v5 has been released some time ago but page does not mention it.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit f10fb4e
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/655b8fd8730ce00008d2b453
😎 Deploy Preview https://deploy-preview-1059--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

</div>

<h2>Ember 4.0.0</h2>
<h2>Ember 4.0.0 and Ember 5.0.0</h2>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved v4 and v5 to the top as that's what I think most ppl would like to see first

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@kategengler
Copy link
Contributor

This seems fine to me but might miss some of the nuance of the browser support policy that started with v4. I am surprised to find #884 never landed.

@SergeAstapov
Copy link
Contributor Author

SergeAstapov commented Nov 6, 2023

@kategengler totally agree! I was pretty sure I would miss some details, but seems like page in current state makes bad impression of being neglected and having some details missed is better than not having totally outdated content.

My assumption would be: if there is no wrong content in here and structure looks good, land it and iterate to clarify and refine the details.

@kategengler
Copy link
Contributor

I think that's fine but do still wonder why #884 was never landed.

For future reference, browser support is a rolling window for the evergreen browsers that can be updated in each minor. Current support can be seen here https://github.com/emberjs/ember.js/blob/main/lib/browsers.js and this is also exported on Ember's index, so in node require('ember').supportedBrowsers gets the list.

This is the relevant RFC https://rfcs.emberjs.com/id/0685-new-browser-support-policy/

https://emberjs.com/browser-support/ states v3 in present tense and talks about v4 in future tense, which is outdated.

Also v5 has been released some time ago but page does not mention it.
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@mansona mansona merged commit 752b2ed into ember-learn:main Nov 20, 2023
6 checks passed
@SergeAstapov SergeAstapov deleted the patch-1 branch November 20, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants