Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser-support #884

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Update browser-support #884

merged 5 commits into from
Nov 20, 2023

Conversation

jaredgalanis
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Dec 17, 2021

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 40e693e
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/655b8d18957ace00080e72f4
😎 Deploy Preview https://deploy-preview-884--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
ember-website.js -1 kB -174 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +3 B

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
ember-website.js -947 B -138 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +1 B

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
ember-website.js -962 B -133 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +1 B

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
ember-website.js -306 B -72 B

Files that stayed the same size 🤷‍:

File raw gzip
blurhash.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +2 B

@stale
Copy link

stale bot commented Mar 2, 2022

This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!

@stale stale bot added the stale label Mar 2, 2022
@jaredgalanis
Copy link
Member Author

not stale

@stale stale bot removed the stale label Mar 2, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!

@stale stale bot added the stale label Jun 12, 2022
@locks locks self-assigned this Jun 13, 2022
@stale stale bot removed the stale label Jun 13, 2022
@chriskrycho
Copy link
Contributor

@jaredgalanis @locks this is a great and much-needed update—can we get it finished up and pushed across the line? 🤩

@chriskrycho
Copy link
Contributor

@locks and I talked about this via DM a bit and we don’t have a perfectly clear idea what the right move here should be. I suspect that instead of listing specific versions for the evergreen browsers, we should just say the policy there, and list specific versions for the browsers which do have specific versions (read: Safari).

@jaredgalanis jaredgalanis force-pushed the update-browser-support branch from a84a7bf to 40e693e Compare November 20, 2023 16:45
Copy link

1/14 Files got Bigger 🚨:

Details
File raw gzip
ember-website.js +33 B +34 B

13/14 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.143.js +2 B +1 B
chunk.177.js 0 B 0 B
chunk.178.js +6 B +9 B
chunk.208.js 0 B 0 B
chunk.488.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B -1 B

Created by ember-asset-size-action

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mansona mansona merged commit 87c7165 into main Nov 20, 2023
7 checks passed
@mansona mansona deleted the update-browser-support branch November 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants