-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add httpx.ReadError
handlers and throw them as OfflineException
#47
Comments
httpx.ConnectTimeout
, httpx.NetworkError
and httpx.PoolTimeout
handlers and throw them as OfflineException
httpx.ReadError
handlers and throw them as OfflineException
I have checked the source code and concluded, the other exceptions where caught, but the I also think there were some issues with |
I wanted to avoid catching too broad exceptions, to avoid masking checker errors that should be dealt with explicitly by checker authors (these should lead to checker errors when not explicitly handled). We should review the httpx-Exceptions and determine which are generic enogh to catch in the checker lib |
here is the tree of exceptions: https://www.python-httpx.org/exceptions/
|
IMO, the general issue is that the common use-case is not met. currently all errors are thrown as internal exceptions which is obviously not the case. Hence most would write a wrapper to handle exceptions, I personally got inspired by underleaf. |
tbh, that is a bit of a horrible way of dealing with exceptions. If a unintended exception occurs, then it should be handled like a checker error. And if there are more 'generic' Exceptions, then it should be dealt with as the correct exception. |
No description provided.
The text was updated successfully, but these errors were encountered: