Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Artists #415

Open
jgdye opened this issue Feb 7, 2024 · 12 comments
Open

Duplicate Artists #415

jgdye opened this issue Feb 7, 2024 · 12 comments

Comments

@jgdye
Copy link

jgdye commented Feb 7, 2024

I'm getting a handful of duplicate artists, where one or two albums are listed under a generic id, and the rest are listed under the MBID. All the files have the correct MBID. I've attached eyeD3 outputs from two files.
This one shows up under the proper MBID.
This one shows up under a generic id.
The difference that I've been able to tell is that the ones with generic ids have both the all caps MUSICBRAINZ_* and "TXX:MusicBrainz *" tags. The problem seems to go away if I delete the MUSICBRAINZ style tags.

@epoupon
Copy link
Owner

epoupon commented Feb 7, 2024

Hello! Thanks for reporting
What lms version do you use?

@epoupon
Copy link
Owner

epoupon commented Feb 7, 2024

And could you please paste the full result of lms-metadata on each file?

@jgdye
Copy link
Author

jgdye commented Feb 8, 2024

Working MBID
Non-working MBID
I was on v3.43.0, but I just compiled v3.49.0 with unchanged results, and that's the version the lms-metadata outputs are from.

@epoupon
Copy link
Owner

epoupon commented Feb 8, 2024

According to what you sent, it looks like TagLib concatenates the values found in both "MUSICBRAINZ_ARTISTID" and "MusicBrainz Artist Id" tags:
Here is what Taglib reports (note the SEP added by lms-metadata to show multiple values):
[MUSICBRAINZ_ARTISTID] = e69db8ef-ffd1-4916-a85f-df428f223cce*SEP*e69db8ef-ffd1-4916-a85f-df428f223cce
LMS tries to perfectly match the artist name and the artist MBID. Here we have a single name for two mbids => no MBID match is even attempted.
For this particular case we could work around this by removing duplicated values.

@epoupon
Copy link
Owner

epoupon commented Feb 8, 2024

Would you mind sending your offending file @ [email protected] ?

@jgdye
Copy link
Author

jgdye commented Feb 8, 2024 via email

@epoupon
Copy link
Owner

epoupon commented Mar 2, 2024

Ok, I think I may have a workaround for this issue. But I am not that confident.
Will have to test more

@epoupon epoupon added this to the v3.51.0 milestone Mar 2, 2024
@epoupon epoupon modified the milestones: v3.51.0, v3.52.0 Mar 15, 2024
@epoupon epoupon modified the milestones: v3.52.0, v3.53.0 Apr 20, 2024
@epoupon epoupon modified the milestones: v3.53.0, v3.54.0 May 1, 2024
@epoupon epoupon removed this from the v3.54.0 milestone Jun 10, 2024
@smooveg1
Copy link

Hi there -- one question as a follow-up here. I have some tracks where musicbrainz_artistid = musicbrainz_albumartistid. However, musicbrainz_releasegroupid does not match. All tracks have matching artist, albumartist, artists, and albumartists tags, which all match with the Musicbrainz description of that artist. The behavior I am getting is that LMS displays as two distinct albumartist/artist entries. My desired output is to display as one single entry. It seems as though the key here may be the ReleaseGroupID tag, but I couldn't find anything in the LMS documentation about how that tag relates to disambiguation. Just checking what the intended behavior is, thank you!

@epoupon
Copy link
Owner

epoupon commented Dec 15, 2024

Hello!
Indeed I have to write some docs about all this :(

What you describes should be supported. A single artist is created in the DB, and this artist has two roles: one track level roles for each track, and one release-level role (album artist) for the release.

If you list "All artists", it should appear only once, but it should be listed in both sublists ("track artists" and "album artists"). Is that the case?

@smooveg1
Copy link

Apologies for the delay, needed to rebuild my Docker image in TrueNas. What you describe is exactly the case, thank you for confirming. What this confirms to me is that the musicbrainz_releasegroupid tag is not part of the disambiguation logic. As long as all the other artist(s) and albumartist(s) tags are built correctly, the DB should not have unintended duplicates. That being said, I wonder if what I was running into was some sort of cache issue where the DB was not being refreshed properly. If this was the case, what would be your recommended procedure to clear out this information and start a fresh library scan?

@epoupon
Copy link
Owner

epoupon commented Dec 17, 2024

Releasegroupid is about releases, not artists. So I am not sure to understand how it is related to your duplicate artist problem?

That being said, performing a full scan ("rescan all files" option in the scanner window) should be enough to get rid of potential cache issues.

@smooveg1
Copy link

Thank you -- that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants