-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Artists #415
Comments
Hello! Thanks for reporting |
And could you please paste the full result of |
Working MBID |
According to what you sent, it looks like TagLib concatenates the values found in both "MUSICBRAINZ_ARTISTID" and "MusicBrainz Artist Id" tags: |
Would you mind sending your offending file @ [email protected] ? |
That's what it looked like to me when I scanned over the output. I would suggest comparing them, using the value if they are the same, and using a generated ID and logging it if different. Picard at least uses the "MusicBrainz Artist Id" tag when tagging, so just using one of the values could cause a file that had the artist changed at some point to show the wrong artist even though Picard and other taggers show the right one.
I sent the file as requested.
February 8, 2024 at 3:02 AM, "Emeric POUPON" ***@***.***> wrote:
…
According to what you sent, it looks like TagLib concatenates the values found in both "MUSICBRAINZ_ARTISTID" and "MusicBrainz Artist Id" tags:
Here is what Taglib reports (note the *SEP* added by lms-metadata to show multiple values):
[MUSICBRAINZ_ARTISTID] = e69db8ef-ffd1-4916-a85f-df428f223cce*SEP*e69db8ef-ffd1-4916-a85f-df428f223cce
LMS tries to perfectly match the artist name and the artist MBID. Here we have a single name for two mbids => no MBID match is even attempted.
For this particular case we could work around this by removing duplicated values.
—
Reply to this email directly, view it on GitHub #415 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDGTDEJQOHGEZ5WDWIQSMLYSSBALAVCNFSM6AAAAABC6K2S5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGU2DCNJXGE .
You are receiving this because you authored the thread.
|
Ok, I think I may have a workaround for this issue. But I am not that confident. |
Hi there -- one question as a follow-up here. I have some tracks where musicbrainz_artistid = musicbrainz_albumartistid. However, musicbrainz_releasegroupid does not match. All tracks have matching artist, albumartist, artists, and albumartists tags, which all match with the Musicbrainz description of that artist. The behavior I am getting is that LMS displays as two distinct albumartist/artist entries. My desired output is to display as one single entry. It seems as though the key here may be the ReleaseGroupID tag, but I couldn't find anything in the LMS documentation about how that tag relates to disambiguation. Just checking what the intended behavior is, thank you! |
Hello! What you describes should be supported. A single artist is created in the DB, and this artist has two roles: one track level roles for each track, and one release-level role (album artist) for the release. If you list "All artists", it should appear only once, but it should be listed in both sublists ("track artists" and "album artists"). Is that the case? |
Apologies for the delay, needed to rebuild my Docker image in TrueNas. What you describe is exactly the case, thank you for confirming. What this confirms to me is that the musicbrainz_releasegroupid tag is not part of the disambiguation logic. As long as all the other artist(s) and albumartist(s) tags are built correctly, the DB should not have unintended duplicates. That being said, I wonder if what I was running into was some sort of cache issue where the DB was not being refreshed properly. If this was the case, what would be your recommended procedure to clear out this information and start a fresh library scan? |
Releasegroupid is about releases, not artists. So I am not sure to understand how it is related to your duplicate artist problem? That being said, performing a full scan ("rescan all files" option in the scanner window) should be enough to get rid of potential cache issues. |
Thank you -- that makes sense. |
I'm getting a handful of duplicate artists, where one or two albums are listed under a generic id, and the rest are listed under the MBID. All the files have the correct MBID. I've attached eyeD3 outputs from two files.
This one shows up under the proper MBID.
This one shows up under a generic id.
The difference that I've been able to tell is that the ones with generic ids have both the all caps MUSICBRAINZ_* and "TXX:MusicBrainz *" tags. The problem seems to go away if I delete the MUSICBRAINZ style tags.
The text was updated successfully, but these errors were encountered: