Inspection view #1806
Closed
Inspection view #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
force-pushed
the
inspection-view
branch
2 times, most recently
from
a637f13 to
012163b
Compare
mrica-equinor
force-pushed
the
inspection-view
branch
2 times, most recently
from
83f4775 to
95b9b4c
Compare
mrica-equinor
force-pushed
the
inspection-view
branch
from
95b9b4c to
42b3728
Compare
mrica-equinor
force-pushed
the
inspection-view
branch
from
42b3728 to
1366129
Compare
oysand
reviewed
Dec 4, 2024
Eddasol
reviewed
Dec 10, 2024
frontend/src/components/Pages/MissionPage/InpectionView/InspectionView.tsx
Show resolved
Hide resolved
Eddasol
reviewed
Dec 10, 2024
frontend/src/components/Pages/MissionPage/InpectionView/InspectionView.tsx
Show resolved
Hide resolved
Eddasol
reviewed
Dec 10, 2024
frontend/src/components/Pages/MissionPage/InpectionView/InspectionView.tsx
Show resolved
Hide resolved
Eddasol
reviewed
Dec 11, 2024
Eddasol
reviewed
Dec 11, 2024
Comment on lines
+25
to
+37
| [Route("{installationCode}/{taskId}/taskId")] | ||
| [ProducesResponseType(typeof(Inspection), StatusCodes.Status200OK)] | ||
| [ProducesResponseType(StatusCodes.Status400BadRequest)] | ||
| [ProducesResponseType(StatusCodes.Status409Conflict)] | ||
| [ProducesResponseType(StatusCodes.Status401Unauthorized)] | ||
| [ProducesResponseType(StatusCodes.Status403Forbidden)] | ||
| [ProducesResponseType(StatusCodes.Status500InternalServerError)] | ||
| public async Task<ActionResult<Inspection>> GetInspectionImageById([FromRoute] string installationCode, string taskId) | ||
| { | ||
| Inspection? inspection; | ||
| try | ||
| { | ||
| inspection = await inspectionService.ReadByIsarTaskId(taskId, readOnly: true); |
There was a problem hiding this comment.
If taskId is isarTaskId, maybe it should be represented in the name to make it more readable
Eddasol
reviewed
Dec 11, 2024
Eddasol
reviewed
Dec 11, 2024
|
"Refactor code" isn't a very good commit message and it seem to contain some fixes of earlier commits. Can it be squashed into the relevant commits? |
eivindsjovold
requested changes
Dec 12, 2024
|
This has been split into two other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.