You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use path/win32 over path.win32 (e.g. here) for path related API functions in Windows-only code. This makes the code more succinct and makes it harder to make mistakes - e.g. accidentally using path.basename instead of path.win.basename.
Per the documentation for path/win32/path.win32, the former was first exposed in 15.3.0:
Version
Changes
v15.3.0
Exposed as require('node:path/win32').
v0.11.15
Added in: v0.11.15
So, this change can't be applied until the lowest supported version of Node.js by Shescape is >=15.3.0 - likely a major version bump that increases the minimum Node.js to v16 when Node.js v14 support has ended.
Background
path/win32 was first imported in the refactoring carried out in #161. After that change was released in v1.5.3 it was identified as a bug (see #197) in older Node.js version. This was patched in #199, which was released in v1.5.4. This issue exists to pick up path/win32 as soon as the minimum Node.js version supported supports it.
Enhancement
Description
Use
path/win32
overpath.win32
(e.g. here) forpath
related API functions in Windows-only code. This makes the code more succinct and makes it harder to make mistakes - e.g. accidentally usingpath.basename
instead ofpath.win.basename
.Per the documentation for
path/win32
/path.win32
, the former was first exposed in 15.3.0:v15.3.0
require('node:path/win32')
.v0.11.15
v0.11.15
So, this change can't be applied until the lowest supported version of Node.js by Shescape is
>=15.3.0
- likely a major version bump that increases the minimum Node.js to v16 when Node.js v14 support has ended.Background
path/win32
was first imported in the refactoring carried out in #161. After that change was released in v1.5.3 it was identified as a bug (see #197) in older Node.js version. This was patched in #199, which was released in v1.5.4. This issue exists to pick uppath/win32
as soon as the minimum Node.js version supported supports it.Relates to: #193
The text was updated successfully, but these errors were encountered: