Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path/win32 import over path.win32 #308

Open
ericcornelissen opened this issue Jun 29, 2022 · 0 comments
Open

Use path/win32 import over path.win32 #308

ericcornelissen opened this issue Jun 29, 2022 · 0 comments
Labels
enhancement New feature or request pending This cannot be worked on yet

Comments

@ericcornelissen
Copy link
Owner

ericcornelissen commented Jun 29, 2022

Enhancement

Description

Use path/win32 over path.win32 (e.g. here) for path related API functions in Windows-only code. This makes the code more succinct and makes it harder to make mistakes - e.g. accidentally using path.basename instead of path.win.basename.

Per the documentation for path/win32/path.win32, the former was first exposed in 15.3.0:

Version Changes
v15.3.0 Exposed as require('node:path/win32').
v0.11.15 Added in: v0.11.15

So, this change can't be applied until the lowest supported version of Node.js by Shescape is >=15.3.0 - likely a major version bump that increases the minimum Node.js to v16 when Node.js v14 support has ended.

Background

path/win32 was first imported in the refactoring carried out in #161. After that change was released in v1.5.3 it was identified as a bug (see #197) in older Node.js version. This was patched in #199, which was released in v1.5.4. This issue exists to pick up path/win32 as soon as the minimum Node.js version supported supports it.


Relates to: #193

@ericcornelissen ericcornelissen added enhancement New feature or request pending This cannot be worked on yet labels Jun 29, 2022
@ericcornelissen ericcornelissen self-assigned this Jun 17, 2023
@ericcornelissen ericcornelissen removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending This cannot be worked on yet
Projects
None yet
Development

No branches or pull requests

1 participant