Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested components resulting in issues on Windows #31

Open
kosmynkab opened this issue Jul 4, 2023 · 7 comments
Open

Nested components resulting in issues on Windows #31

kosmynkab opened this issue Jul 4, 2023 · 7 comments

Comments

@kosmynkab
Copy link

The following glyphs glyphs have nested components:
Dcroat
gcommaaccent
ij
nine.tf
onehalf
onequarter
threequarters
oneeighth
threeeighths
fiveeighths
seveneighths
zeroinferior
oneinferior
twoinferior
threeinferior
fourinferior
fiveinferior
sixinferior
seveninferior
eightinferior
nineinferior
periodcentered.loclCAT
space
periodcentered.loclCAT.case
quotedblbase
quotedblright
guillemetright
lessequal

@kenmcd
Copy link

kenmcd commented Jul 4, 2023

What applications have you had issues with?

@kosmynkab
Copy link
Author

kosmynkab commented Jul 4, 2023

Microsoft Office on Windows machines for instance the quotedblbase displays as a single quote and prints as a single quote. Had the issue in the past in my own fonts – the source is the double nested components, which Google advises to get rid of in the files. I opened the source files in Glyphs and double checked that this is the issue.

@kenmcd
Copy link

kenmcd commented Jul 5, 2023

Thanks. I was just curious which apps were affected.
Hmmmm...
There is a Font Bakery check which is supposed to check this.
And the v2.001 fonts were merged/updated last week.
But I see nothing in the FB report here: google/fonts#6465
Perhaps @emmamarichal can shed some light on this.

@emmamarichal
Copy link
Contributor

Hi @kosmynkab!
Thanks for this report. Did you test with the current version on the API (2.000)?
An update will be onboarded soon (2.001), and this is the result I got on Windows (Word). I don't have any problems linked to the nested components. But indeed, there are still a few left in the files (the ones you mentioned). If there are too many problems, we'll do an update by decomposing them.

Capture d’écran 2023-07-06 à 10 26 02

@kenmcd
Copy link

kenmcd commented Jul 6, 2023

Microsoft Office on Windows machines

What version of Office?
Windows 10?

@kosmynkab
Copy link
Author

kosmynkab commented Jul 6, 2023

Microsoft Office Standard 2016
Windows 10 Pro 22H2
(Relaying information from the client)

image
The first bottom quote should be quotedblbase

I had exactly the same characters and exactly the same issue with them with the custom typefaces that I prepared for them.

The files I used were the ones that they are using which come from the fonts.google website, however I tried with files exported from the Glyphs source files from Github on my end and the issue was the same. Just want to make sure that they are using exactly the same version of the font as the one available on GF and also that Figtree is ultimately bug free.
Great typeface by the way, should have opened with that! ;)

@emmamarichal
Copy link
Contributor

@kosmynkab Ok thanks!
I removed nested components on my fork, and exported the variable. Could you test with this version?
https://github.com/emmamarichal/figtree/tree/master/fonts/variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants