Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference subscriptions by id #8

Open
eskimor opened this issue Aug 24, 2016 · 0 comments
Open

Reference subscriptions by id #8

eskimor opened this issue Aug 24, 2016 · 0 comments
Labels
enhancement

Comments

@eskimor
Copy link
Owner

eskimor commented Aug 24, 2016

Now that we no longer reference subscriptions by path, but by Request it might make sense to use ids. This would reduce network overhead quite a bit.

Response would be changed to something like:

data Response = 
    Subscribed !R.HttpRequest !Int
  | Modified !Int !ResponseBody  
  | Deleted !Path
  | Unsubscribed !Int
  | HttpRequestFailed !Int !R.HttpRequest !HttpResponse 
  | ParseError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eskimor