The Same remote source ingested twice inside a single ADO will make File persister Fail

[DiegoPino]

What?

Extra edge case (and a fatal one)

strawberryfield/src/StrawberryfieldFilePersisterService.php

Lines 794 to 816 in d498c09

	if (isset($flatvalues[self::FILE_IRI_PREFIX . $uuid]) &&
	isset($flatvalues[self::FILE_IRI_PREFIX . $uuid]['dr:fid']) &&
	($flatvalues[self::FILE_IRI_PREFIX . $uuid]['dr:fid'] = $fid) &&
	isset($flatvalues[self::FILE_IRI_PREFIX . $uuid]['url']) &&
	!empty($flatvalues[self::FILE_IRI_PREFIX . $uuid]['url'])) {
	// Weird egde case:
	// What if same urn:uuid:uuid has multiple info structures?
	// Flattener could end being double nested?
	$destination_uri = $flatvalues[self::FILE_IRI_PREFIX . $uuid]['url'];
	// Only deal with expensive process if destination uri is
	// different to the known one.
	if ($destination_uri != $current_uri) {
	$destination_folder = $this->fileSystem
	->dirname($destination_uri);
	$this->fileSystem->prepareDirectory(
	$destination_folder,
	FileSystemInterface::CREATE_DIRECTORY | FileSystemInterface::MODIFY_PERMISSIONS
	);
	// Copy to new destination
	$destination_uri = $this->fileSystem->copy(
	$current_uri,
	$destination_uri
	);

But if e.g an AMI column (images) contains http://myimage.com/image1.jpeg and (docs) contains http://myimage.com/image2.jpeg when persisting the matching will mean that the flattener will bring url as an array containing TWICE the same final destination.

The solution (hard to trigger error) is in the case of an ARRAY with URLs, we can compare them, if both are the same, then we pick one, if not, then well, that can not be and we die with errors

[DiegoPino]

@alliomeria what you saw today with the double /OBJ datastreams

[aksm]

@DiegoPino Have you started work on this already? Should I try to tackle it?