Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Notifications and Channel Are Deprecated, Add support for New Alerting Entities #134

Open
1 of 4 tasks
safaci2000 opened this issue Mar 28, 2023 · 6 comments
Open
1 of 4 tasks
Assignees
Milestone

Comments

@safaci2000
Copy link
Contributor

safaci2000 commented Mar 28, 2023

Task List

  • ContactPoints
  • AlertRules
  • NotificationPolicy
  • Templates

Remove all the Alert Notifications code and replace with the newly updated entities.

https://grafana.com/docs/grafana/latest/developers/http_api/alerting_provisioning/

Channels are now Contact Points

Alert Rules would replace the Notifications.

@safaci2000 safaci2000 added this to the 0.4.0 milestone Mar 28, 2023
@safaci2000 safaci2000 moved this to Todo in GDG Development Mar 31, 2023
@safaci2000 safaci2000 modified the milestones: 0.4.0, 0.4.1 Mar 31, 2023
@safaci2000
Copy link
Contributor Author

This is a bit more involved than I had anticipated. I may push this back to another release.

But for this to really be useful, from what I'm reading on: https://grafana.com/docs/grafana/latest/developers/http_api/alerting_provisioning/

We would need:

Required:

  • ContactPoints,
    -AlertRules
    -NotificationPolicy
  • Templates

Nice to Have:

  • Mute Timings

I need to dig a bit more into this but will push this back a bit.

@safaci2000 safaci2000 changed the title Alert Notifications and Channel Are Deprecated Alert Notifications and Channel Are Deprecated, Add support for New Alerting Entities Mar 31, 2023
@safaci2000 safaci2000 moved this to Todo in GDG Development Apr 2, 2023
@safaci2000 safaci2000 modified the milestones: 0.4.1, 0.4.2 Apr 3, 2023
@safaci2000 safaci2000 modified the milestones: 0.4.2, 0.4.3 Apr 11, 2023
@safaci2000 safaci2000 modified the milestones: 0.4.5, 0.4.6 Jul 14, 2023
@safaci2000 safaci2000 modified the milestones: 0.4.6, 0.4.7 Aug 10, 2023
@mbarrien
Copy link

I filed grafana/grafana#76578 which may be blocking some of the issues you ran into here. The OpenAPI spec provided by Grafana is broken for their new provisioning API, which includes alert rules, contact points, mute timings, and policies.

@safaci2000
Copy link
Contributor Author

Oh thanks, I actually ran into that recently and even opened up a ticket for them as well. grafana/grafana#76386.

I'd like to start doing some work on this, at least the contact points should be easy enough to add. Thanks for the link @mbarrien

@safaci2000 safaci2000 modified the milestones: 0.5.1, 0.5.2 Oct 25, 2023
@safaci2000 safaci2000 removed this from the 0.5.2 milestone Nov 7, 2023
@safaci2000 safaci2000 added this to the 0.5.3 milestone Nov 7, 2023
@safaci2000
Copy link
Contributor Author

@mbarrien I'm dropping the legacy support in 0.6.0. I'll try to address this in 0.6.1. Is there any particular priority that is more pressing for you? I think there's 4 Entities at least listed in the ticket. This feature might not have much value without all of them but wanted to call it out to see if any particular order makes sense.

@safaci2000
Copy link
Contributor Author

safaci2000 commented Oct 18, 2024

#302 ContactPoints. This is essentially done. (ContactPoints I mean). The 'email receiver' is super weird for some reason so GDG will ignore it. Otherwise everything else seems to work.

@safaci2000
Copy link
Contributor Author

Bug in AlertRules blocking for now: grafana/grafana-openapi-client-go#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants