You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Uncaught (in promise) TypeError: Cannot read property 'props' of null
at ChartRow.js:377
at forEachSingleChild (react.development.js:1118)
at traverseAllChildrenImpl (react.development.js:1007)
...
To Reproduce
Steps to reproduce the behavior:
Pass a null into the children for a <Charts> instance
View crash
Expected behavior nulls are handle. I believe it's just a matter of adding if (chart === null) return; to line 317 of ChartRow.js
want me to send a PR?
The text was updated successfully, but these errors were encountered:
🐛Bug report
Describe the bug
I want to do this:
I might have multiple events at a given timestamp. If I do, I don't want to render a line.
Most places where
children
are looped over,null
s are checked:react-timeseries-charts/src/components/ChartRow.js
Lines 312 to 313 in aa9c9b3
but there's no check here:
react-timeseries-charts/src/components/ChartRow.js
Lines 316 to 317 in aa9c9b3
resulting in this stack trace:
To Reproduce
Steps to reproduce the behavior:
null
into thechildren
for a<Charts>
instanceExpected behavior
null
s are handle. I believe it's just a matter of addingif (chart === null) return;
to line 317 of ChartRow.jswant me to send a PR?
The text was updated successfully, but these errors were encountered: