Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional warning: calendar_dates for everything #124

Open
AntoineAugusti opened this issue Apr 22, 2022 · 2 comments
Open

Additional warning: calendar_dates for everything #124

AntoineAugusti opened this issue Apr 22, 2022 · 2 comments

Comments

@AntoineAugusti
Copy link
Member

From etalab/transport-site#2331

The file only uses overrides and not regular schedules + overrides

@antoine-de
Copy link
Member

hum, I'm not sure about this one 🤔

I think it's a common practice to do this isn't it @Tristramg ?

It is explicitly stated as an alternative strategy by the spec:

Alternate: Omit calendar.txt, and specify each date of service in calendar_dates.txt. This allows for considerable service variation and accommodates service without normal weekly schedules. In this case service_id is an ID.

It sure is more troublesome to some reuses, but I'm not sure it should be added in a validator (even as information).

What do you think about this @Tristramg @AntoineAugusti ?

@Tristramg
Copy link
Collaborator

There can’t be a general rule. If some bus runs on weird patterns like only on a public holiday, using dates makes sens.
If the schedule is very regular, a calendar is nicer.

We could imagine a metric trying to tell which approach would be better, but it’s not an easy task and probably not worth it.

Maybe something like « if there are more than N calendar_dates for a trip, and no calendar » add an information ?
We’d need to see an example file where people are annoyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants